refactor: clean up the code

Author: z0al

lib/lint.js

@@ -5,18 +5,6 @@ const { lint, load } = require('@commitlint/core')
 const config = require('./config')
 const format = require('./format')
 
-// Globals
-const baseStatus = {
-	context: 'commitlint-bot',
-	// commitlint rules reference URL
-	target_url: 'http://npm.im/@commitlint/config-angular#problems'
-}
-const pendingStatus = {
-	...baseStatus,
-	state: 'pending',
-	description: 'Running commitlint for this PR'
-}
-
 /**
  * Runs commitlint over all commits of the pull request and sets an appropriate
  * status check
@@ -29,11 +17,17 @@ const commitlint = async ({ github, payload }) => {
 	const statusInfo = {
 		sha: payload.pull_request.head.sha,
 		repo: name,
-		owner: owner.login
+		owner: owner.login,
+		context: 'commitlint-bot',
+		target_url: 'http://npm.im/@commitlint/config-angular#problems'
 	}
 
 	// Pending
-	github.repos.createStatus({ ...statusInfo, ...pendingStatus })
+	github.repos.createStatus({
+		...statusInfo,
+		state: 'pending',
+		description: 'Waiting for the status to be reported'
+	})
 
 	// Paginate all PR commits
 	github.paginate(
@@ -56,7 +50,6 @@ const commitlint = async ({ github, payload }) => {
 			// Final report
 			github.repos.createStatus({
 				...statusInfo,
-				...baseStatus,
 				state: report.valid ? 'success' : 'error',
 				description: format(report)
 			})