Skip to content

Commit 42e8af2

Browse files
author
coteeq
committed
Remove TryEmplaceOrCrash
It has exactly the same behaviour as EmplaceOrCrash and the performance benefit is immediately discarded by YT\_VERIFY. commit_hash:3160e939549b9fd83fd69fa4c67b7070901b4828
1 parent 5eb6126 commit 42e8af2

File tree

2 files changed

+0
-17
lines changed

2 files changed

+0
-17
lines changed

yt/yt/core/misc/collection_helpers-inl.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -203,14 +203,6 @@ auto EmplaceOrCrash(TContainer&& container, TArgs&&... args)
203203
return it;
204204
}
205205

206-
template <class TContainer, class... TArgs>
207-
auto TryEmplaceOrCrash(TContainer&& container, TArgs&&... args)
208-
{
209-
auto [it, emplaced] = container.try_emplace(std::forward<TArgs>(args)...);
210-
YT_VERIFY(emplaced);
211-
return it;
212-
}
213-
214206
template <class TMap, class TKey>
215207
auto EmplaceDefault(TMap&& map, TKey&& key)
216208
{

yt/yt/core/misc/collection_helpers.h

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -99,15 +99,6 @@ auto InsertOrCrash(TContainer&& container, TArg&& arg);
9999
template <class TContainer, class... TArgs>
100100
auto EmplaceOrCrash(TContainer&& container, TArgs&&... args);
101101

102-
/*!
103-
* This function is supposed to replace a frequent pattern
104-
* YT_VERIFY(map.try_emplace(key, value).second);
105-
* with
106-
* TryEmplaceOrCrash(map, key, value);
107-
*/
108-
template <class TContainer, class... TArgs>
109-
auto TryEmplaceOrCrash(TContainer&& container, TArgs&&... args);
110-
111102
/*!
112103
* This function emplaces default value at the given key.
113104
*/

0 commit comments

Comments
 (0)