Skip to content

Commit e252b8b

Browse files
orloffvasmyasnikovkprokopenko
authored
feat(ratelimiter): export options package (#1966)
Co-authored-by: Aleksey Myasnikov <asmyasnikov@ydb.tech> Co-authored-by: Konstantin Prokopenko <kprokopenko@users.noreply.github.com>
1 parent d0672b0 commit e252b8b

File tree

4 files changed

+4
-7
lines changed

4 files changed

+4
-7
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
* Changed internal pprof label to pyroscope supported format
22
* Added `query.ImplicitTxControl()` transaction control (the same as `query.NoTx()` and `query.EmptyTxControl()`). See more about implicit transactions on [ydb.tech](https://ydb.tech/docs/en/concepts/transactions?version=v25.2#implicit)
33
* Added `SnapshotReadWrite` isolation mode support to `database/sql` driver using `sql.TxOptions{Isolation: sql.LevelSnapshot, ReadOnly: false}`
4+
* Move `internal/ratelimiter/options` to `ratelimiter/options` for public usage
45

56
## v3.120.0
67
* Added support of `SnapshotReadWrite` isolation mode into query and table clients

internal/ratelimiter/client.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ import (
1313
"github.com/ydb-platform/ydb-go-sdk/v3/internal/operation"
1414
"github.com/ydb-platform/ydb-go-sdk/v3/internal/ratelimiter/config"
1515
ratelimiterErrors "github.com/ydb-platform/ydb-go-sdk/v3/internal/ratelimiter/errors"
16-
"github.com/ydb-platform/ydb-go-sdk/v3/internal/ratelimiter/options"
1716
"github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors"
1817
"github.com/ydb-platform/ydb-go-sdk/v3/ratelimiter"
18+
"github.com/ydb-platform/ydb-go-sdk/v3/ratelimiter/options"
1919
"github.com/ydb-platform/ydb-go-sdk/v3/retry"
2020
)
2121

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@ package options
22

33
import "time"
44

5-
const (
6-
DefaultDecrease = 100 * time.Millisecond
7-
)
8-
95
type AcquireType uint8
106

117
const (
@@ -37,7 +33,7 @@ func (h *acquireOptionsHolder) OperationTimeout() time.Duration {
3733
}
3834

3935
func (h *acquireOptionsHolder) OperationCancelAfter() time.Duration {
40-
return h.operationTimeout
36+
return h.operationCancelAfter
4137
}
4238

4339
func (h *acquireOptionsHolder) Type() AcquireType {

ratelimiter/ratelimiter.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import (
44
"context"
55
"time"
66

7-
"github.com/ydb-platform/ydb-go-sdk/v3/internal/ratelimiter/options"
7+
"github.com/ydb-platform/ydb-go-sdk/v3/ratelimiter/options"
88
)
99

1010
type Client interface {

0 commit comments

Comments
 (0)