moved build logic to ext file

Author: qrort

.github/scripts/build-slo-image.sh

@@ -10,14 +10,16 @@ Usage:
     --tag <docker-tag> \
     --src-path <sdk-path> \
     --job-name <job-name> \
-    --ref <git-ref>
+    --ref <git-ref> \
+    --fallback-image <docker-tag>
 
 Options:
-  --context     Docker build context directory (e.g. $GITHUB_WORKSPACE/current).
-  --tag         Docker image tag to build (e.g. ydb-app-current).
-  --src-path    Value for Docker build arg SRC_PATH (e.g. native/table).
-  --job-name    Value for Docker build arg JOB_NAME (e.g. native-table).
-  --ref         Value for Docker build arg REF (e.g. branch name / sha).
+  --context         Docker build context directory (e.g. $GITHUB_WORKSPACE/current).
+  --tag             Docker image tag to build (e.g. ydb-app-current).
+  --src-path        Value for Docker build arg SRC_PATH (e.g. native/table).
+  --job-name        Value for Docker build arg JOB_NAME (e.g. native-table).
+  --ref             Value for Docker build arg REF (e.g. branch name / sha).
+  --fallback-image  Image tag to return if initial Docker image build fails
 EOF
 }
 
@@ -32,6 +34,7 @@ tag=""
 ref=""
 src_path=""
 job_name=""
+fallback_image=""
 
 while [[ $# -gt 0 ]]; do
   case "$1" in
@@ -55,6 +58,10 @@ while [[ $# -gt 0 ]]; do
       job_name="${2:-}"
       shift 2
       ;;
+    --fallback-image)
+      fallback_image="${2:-}"
+      shift 2
+      ;;
     -h|--help)
       usage
       exit 0
@@ -67,7 +74,7 @@ done
 
 if [[ -z "$context_dir" || -z "$tag" || -z "$src_path" || -z "$job_name" || -z "$ref" ]]; then
   usage
-  exit 2
+  die "Incomplete argument set"
 fi
 
 [[ -d "$context_dir" ]] || die "--context does not exist: $context_dir"
@@ -82,10 +89,22 @@ echo "  SRC_PATH:   $src_path"
 echo "  JOB_NAME:   $job_name"
 
 (
+  set +e
   cd "$context_dir"
   docker build -t "$tag" \
     --build-arg "SRC_PATH=$src_path" \
     --build-arg "JOB_NAME=$job_name" \
     --build-arg "REF=$ref" \
     -f "$dockerfile" .
+  exit_code=$?
+  echo "Docker build exit code: $exit_code"
+  if [ $exit_code -ne 0 ]; then
+    if [[ -z "$fallback_image" ]]; then
+      die "Docker build failed and --fallback-image is not set" >&2
+    fi
+
+    echo "Baseline build failed, using fallback image: $fallback_image"
+    docker tag "$fallback_image" "$tag"
+  fi
+  set -e
 )

.github/workflows/slo.yml

@@ -81,6 +81,8 @@ jobs:
             name: native-node-hints
             path: ./native/node_hints
             label: native/node_hints
+            slo_workload_read_max_rps: 100
+            slo_workload_write_max_rps: 100
             run_extra_args: '-batch-size=10'
             create_extra_args: '-min-partitions-count 10'
 
@@ -174,7 +176,8 @@ jobs:
             --tag "ydb-app-baseline" \
             --ref "${{ steps.baseline.outputs.ref }}" \
             --src-path "${{ matrix.sdk.label }}" \
-            --job-name "${{ matrix.sdk.name }}"
+            --job-name "${{ matrix.sdk.name }}" \
+            --fallback-image "ydb-app-current"
 
       - name: Initialize YDB SLO
         id: ydb_slo

tests/slo/native/node_hints/main.go

@@ -152,7 +152,7 @@ func main() {
 		wg.Wait()
 		w.FailOnError()
 		// check all load is sent to a single node
-		ectx, ecancel := context.WithTimeout(context.Background(), 1*time.Second)
+		ectx, ecancel := context.WithTimeout(context.Background(), 10*time.Second)
 		defer ecancel()
 		estimator.OnlyThisNode(ectx, nodeID)