lint, "test fail"

Author: qrort

.github/resources/slo-report-thresholds.yaml

@@ -66,6 +66,6 @@ metrics:
     direction: lower_is_better
     warning_max: 0.1
     critical_max: 1.0
-  - pattern: "*_node_hints.misses*"
+  - pattern: "*_node_hints_misses_total*"
     direction: lower_is_better
     critical_max: 0 # more than zero and node_hints workload fails

tests/slo/internal/metrics/metrics.go

@@ -46,7 +46,7 @@ type (
 		retriesSuccessTotal     otelmetric.Int64Counter
 		retriesFailureTotal     otelmetric.Int64Counter
 		pendingOperations       otelmetric.Int64UpDownCounter
-		nodeHintMissesPresent   otelmetric.Int64Counter
+		nodeHintMissesPresent   otelmetric.Int64UpDownCounter
 	}
 )
 
@@ -202,7 +202,7 @@ func New(endpoint, ref, label, jobName string, reportPeriodMs int) (*Metrics, er
 	if err != nil {
 		return nil, fmt.Errorf("failed to create pendingOperations counter: %w", err)
 	}
-	m.nodeHintMissesPresent, err = m.meter.Int64Counter(
+	m.nodeHintMissesPresent, err = m.meter.Int64UpDownCounter(
 		"workload.node_hints.misses",
 		otelmetric.WithDescription("Exclusively for node_hints SLO workload: Signals GRPC requests to wrong node"),
 	)
@@ -262,9 +262,9 @@ func (m *Metrics) Start(name SpanName) Span {
 	return j
 }
 
-func (m *Metrics) ReportNodeHintMisses() {
+func (m *Metrics) ReportNodeHintMisses(val int64) {
 	if m.meter != nil {
-		m.nodeHintMissesPresent.Add(m.ctx, 1)
+		m.nodeHintMissesPresent.Add(m.ctx, val)
 	}
 }
 

tests/slo/internal/workers/workers.go

@@ -58,9 +58,9 @@ func NewWithBatch(cfg *config.Config, s BatchReadWriter, ref, label, jobName str
 	}, nil
 }
 
-func (w *Workers) ReportNodeHintMisses() {
+func (w *Workers) ReportNodeHintMisses(val int64) {
 	if w.m != nil {
-		w.m.ReportNodeHintMisses()
+		w.m.ReportNodeHintMisses(val)
 	}
 }
 

tests/slo/native/node_hints/dynnode_traffic.go

@@ -143,5 +143,6 @@ func (e *Estimator) OnlyThisNode(ctx context.Context, nodeID uint32) error {
 			e.NodeRequests[nodeID], nodeNow,
 		)
 	}
+
 	return nil
 }

tests/slo/native/node_hints/main.go

@@ -114,6 +114,7 @@ func main() {
 		if err != nil {
 			panic(fmt.Errorf("create workers failed: %w", err))
 		}
+		w.ReportNodeHintMisses(1)
 		ns := s.nodeSelector.Load()
 		idx, nodeID := ns.GetRandomNodeID(gen)
 		log.Println("all requests to node id: ", nodeID)
@@ -150,7 +151,7 @@ func main() {
 		defer ecancel()
 		err = estimator.OnlyThisNode(ectx, nodeID)
 		if err != nil {
-			w.ReportNodeHintMisses()
+			w.ReportNodeHintMisses(-1)
 			time.Sleep(w.ExportInterval())
 		}
 	default: