Skip to content

Commit 0a44bbb

Browse files
committed
lint, "test fail"
1 parent cc9e0db commit 0a44bbb

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

.github/resources/slo-report-thresholds.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,6 @@ metrics:
6666
direction: lower_is_better
6767
warning_max: 0.1
6868
critical_max: 1.0
69-
- pattern: "*_node_hints.misses*"
69+
- pattern: "*_node_hints_misses_total*"
7070
direction: lower_is_better
7171
critical_max: 0 # more than zero and node_hints workload fails

tests/slo/native/node_hints/dynnode_traffic.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,5 +143,6 @@ func (e *Estimator) OnlyThisNode(ctx context.Context, nodeID uint32) error {
143143
e.NodeRequests[nodeID], nodeNow,
144144
)
145145
}
146+
146147
return nil
147148
}

tests/slo/native/node_hints/main.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -149,10 +149,10 @@ func main() {
149149
ectx, ecancel := context.WithTimeout(context.Background(), 10*time.Second)
150150
defer ecancel()
151151
err = estimator.OnlyThisNode(ectx, nodeID)
152-
if err != nil {
153-
w.ReportNodeHintMisses()
154-
time.Sleep(w.ExportInterval())
155-
}
152+
//if err != nil {
153+
w.ReportNodeHintMisses()
154+
time.Sleep(w.ExportInterval())
155+
//}
156156
default:
157157
panic(fmt.Errorf("unknown mode: %v", cfg.Mode))
158158
}

0 commit comments

Comments
 (0)