Better error report when facing dimension mismatch

serge-sans-paille · serge-sans-paille · commit dfb2dce3d92c · 2019-11-25T17:02:05.000+01:00
diff --git a/include/xtensor-python/pycontainer.hpp b/include/xtensor-python/pycontainer.hpp
@@ -12,6 +12,7 @@
 #include <cmath>
 #include <functional>
 #include <numeric>
+#include <sstream>
 
 #include "pybind11/complex.h"
 #include "pybind11/pybind11.h"
@@ -338,7 +339,10 @@ namespace xt
             {
                 if(new_dim != N)
                 {
-                    throw std::runtime_error("Dims not matching.");
+                    std::ostringstream err_msg;
+                    err_msg << "Invalid conversion to pycontainer, expecting a container of dimension "
+                            << N << ", got a container of dimension " << new_dim << ".";
+                    throw std::runtime_error(err_msg.str());
                 }
                 return new_dim == N;
             }

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`	`#include <cmath>`
`13`	`13`	`#include <functional>`
`14`	`14`	`#include <numeric>`
	`15`	`+#include <sstream>`
`15`	`16`
`16`	`17`	`#include "pybind11/complex.h"`
`17`	`18`	`#include "pybind11/pybind11.h"`
`@@ -338,7 +339,10 @@ namespace xt`
`338`	`339`	`{`
`339`	`340`	`if(new_dim != N)`
`340`	`341`	`{`
`341`		`- throw std::runtime_error("Dims not matching.");`
	`342`	`+ std::ostringstream err_msg;`
	`343`	`+ err_msg << "Invalid conversion to pycontainer, expecting a container of dimension "`
	`344`	`+ << N << ", got a container of dimension " << new_dim << ".";`
	`345`	`+ throw std::runtime_error(err_msg.str());`
`342`	`346`	`}`
`343`	`347`	`return new_dim == N;`
`344`	`348`	`}`