Skip to content

Commit 4ceccc2

Browse files
committed
make testsuite more robust
1 parent cc64f71 commit 4ceccc2

File tree

1 file changed

+27
-12
lines changed

1 file changed

+27
-12
lines changed

tests/testsuite.py

Lines changed: 27 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,10 @@ def test_doctest_example(self):
6161
runner.run(suite)
6262
outdir.seek(0)
6363
output = outdir.read()
64-
self.assertIn('classname="tests.doctest_example.Multiplicator" '
65-
'name="threetimes"'.encode('utf8'), output)
66-
self.assertIn('classname="tests.doctest_example" '
67-
'name="twice"'.encode('utf8'), output)
64+
self.assertIn('classname="tests.doctest_example.Multiplicator"'.encode('utf8'), output)
65+
self.assertIn('name="threetimes"'.encode('utf8'), output)
66+
self.assertIn('classname="tests.doctest_example"'.encode('utf8'), output)
67+
self.assertIn('name="twice"'.encode('utf8'), output)
6868

6969

7070
@contextlib.contextmanager
@@ -222,13 +222,20 @@ def test_classnames(self):
222222
output = outdir.read()
223223
self.assertRegexpMatches(
224224
output,
225-
r'classname="tests\.testsuite\.(XMLTestRunnerTestCase\.)?'
226-
r'DummyTest" name="test_pass"'.encode('utf8'),
225+
r'classname="tests\.testsuite\.(XMLTestRunnerTestCase\.)?DummyTest'.encode('utf8'),
227226
)
228227
self.assertRegexpMatches(
229228
output,
230-
r'classname="tests\.testsuite\.(XMLTestRunnerTestCase\.)?'
231-
r'DummySubTest" name="test_subTest_pass"'.encode('utf8'))
229+
r'name="test_pass"'.encode('utf8'),
230+
)
231+
self.assertRegexpMatches(
232+
output,
233+
r'classname="tests\.testsuite\.(XMLTestRunnerTestCase\.)?DummySubTest'.encode('utf8'),
234+
)
235+
self.assertRegexpMatches(
236+
output,
237+
r'name="test_subTest_pass"'.encode('utf8'),
238+
)
232239

233240
def test_xmlrunner_non_ascii(self):
234241
suite = unittest.TestSuite()
@@ -419,12 +426,16 @@ def test_unittest_subTest_fail(self):
419426
self.assertRegexpMatches(
420427
output,
421428
br'<testcase classname="tests\.testsuite\.'
422-
br'(XMLTestRunnerTestCase\.)?DummySubTest" '
429+
br'(XMLTestRunnerTestCase\.)?DummySubTest"')
430+
self.assertRegexpMatches(
431+
output,
423432
br'name="test_subTest_fail \(i=0\)"')
424433
self.assertRegexpMatches(
425434
output,
426435
br'<testcase classname="tests\.testsuite\.'
427-
br'(XMLTestRunnerTestCase\.)?DummySubTest" '
436+
br'(XMLTestRunnerTestCase\.)?DummySubTest"')
437+
self.assertRegexpMatches(
438+
output,
428439
br'name="test_subTest_fail \(i=1\)"')
429440

430441
@unittest.skipIf(not hasattr(unittest.TestCase, 'subTest'),
@@ -443,12 +454,16 @@ def test_unittest_subTest_error(self):
443454
self.assertRegexpMatches(
444455
output,
445456
br'<testcase classname="tests\.testsuite\.'
446-
br'(XMLTestRunnerTestCase\.)?DummySubTest" '
457+
br'(XMLTestRunnerTestCase\.)?DummySubTest"')
458+
self.assertRegexpMatches(
459+
output,
447460
br'name="test_subTest_error \(i=0\)"')
448461
self.assertRegexpMatches(
449462
output,
450463
br'<testcase classname="tests\.testsuite\.'
451-
br'(XMLTestRunnerTestCase\.)?DummySubTest" '
464+
br'(XMLTestRunnerTestCase\.)?DummySubTest"')
465+
self.assertRegexpMatches(
466+
output,
452467
br'name="test_subTest_error \(i=1\)"')
453468

454469
@unittest.skipIf(not hasattr(unittest.TestCase, 'subTest'),

0 commit comments

Comments
 (0)