If CheckAll fails, the return error code is 3

Author: Avi SZYCHTER

utils/can-parse/can-parse.cpp

@@ -150,7 +150,12 @@ int main(int argc, char** argv) {
     break;
 
     case CheckAll:
-      check_all_frames(db, warnings);
+      {
+        if(!check_all_frames(db, warnings)) {
+          // CheckAll failed, we return an non-zero error-code.
+          return 3;
+        }
+      }
       break;
 
     case Help:

utils/can-parse/check-frame.cpp

@@ -3,7 +3,7 @@
 #include "CANDatabase.h"
 #include <algorithm>
 
-void CppCAN::can_parse::check_all_frames(CANDatabase& db, const std::vector<CANDatabase::parsing_warning>& warnings) {
+bool CppCAN::can_parse::check_all_frames(CANDatabase& db, const std::vector<CANDatabase::parsing_warning>& warnings) {
   std::vector<uint32_t> ids;
 
   if(warnings.size() > 0) {
@@ -31,4 +31,9 @@ void CppCAN::can_parse::check_all_frames(CANDatabase& db, const std::vector<CAND
     }
     std::cout << ids.back() << std::endl;
   }
+
+  if(warnings.size() > 0 || ids.size() > 0)
+    return false;
+  
+  return true;
 }

utils/can-parse/operations.h

@@ -22,7 +22,7 @@ namespace can_parse {
     /**
      * @brief Checks the validity of all the frames of the database
      */
-    void check_all_frames(CANDatabase& db, const std::vector<CANDatabase::parsing_warning>& warnings);
+    bool check_all_frames(CANDatabase& db, const std::vector<CANDatabase::parsing_warning>& warnings);
 
     /**
      * Exception thrown by any operation if an error happens during their