Skip to content

Commit aab9fed

Browse files
guidiazaesedepece
authored andcommitted
fix(json_rpc): avoid ever providing node's stake entries
1 parent 1085fce commit aab9fed

File tree

2 files changed

+21
-25
lines changed

2 files changed

+21
-25
lines changed

src/cli/node/json_rpc_client.rs

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,12 @@ use witnet_node::actors::{
5151
chain_manager::run_dr_locally,
5252
json_rpc::api::{
5353
AddrType, GetBlockChainParams, GetTransactionOutput, PeersResult, QueryPowersParams,
54-
QueryPowersRecord, QueryStakesParams,
54+
QueryPowersRecord,
5555
},
5656
messages::{
5757
AuthorizeStake, BuildDrt, BuildStakeParams, BuildStakeResponse, BuildUnstakeParams,
58-
BuildVtt, GetBalanceTarget, GetReputationResult, MagicEither, SignalingInfo,
59-
StakeAuthorization,
58+
BuildVtt, GetBalanceTarget, GetReputationResult, MagicEither, QueryStakes,
59+
QueryStakesFilter, QueryStakesLimits, SignalingInfo, StakeAuthorization,
6060
},
6161
};
6262
use witnet_rad::types::RadonTypes;
@@ -1952,21 +1952,26 @@ pub fn query_stakes(
19521952
addr: SocketAddr,
19531953
validator: Option<String>,
19541954
withdrawer: Option<String>,
1955-
all: bool,
19561955
long: bool,
19571956
) -> Result<(), failure::Error> {
19581957
let mut stream = start_client(addr)?;
1959-
let params = if all {
1960-
Some(QueryStakesParams::All(true))
1961-
} else {
1962-
match (validator, withdrawer) {
1963-
(Some(validator), Some(withdrawer)) => {
1964-
Some(QueryStakesParams::Key((validator, withdrawer)))
1965-
}
1966-
(Some(validator), _) => Some(QueryStakesParams::Validator(validator)),
1967-
(_, Some(withdrawer)) => Some(QueryStakesParams::Withdrawer(withdrawer)),
1968-
(None, None) => None,
1969-
}
1958+
let params = match (validator, withdrawer) {
1959+
(Some(validator), Some(withdrawer)) => QueryStakes {
1960+
filter: QueryStakesFilter::Key((
1961+
MagicEither::Left(validator),
1962+
MagicEither::Left(withdrawer),
1963+
)),
1964+
limits: QueryStakesLimits::default(),
1965+
},
1966+
(Some(validator), _) => QueryStakes {
1967+
filter: QueryStakesFilter::Validator(MagicEither::Left(validator)),
1968+
limits: QueryStakesLimits::default(),
1969+
},
1970+
(_, Some(withdrawer)) => QueryStakes {
1971+
filter: QueryStakesFilter::Withdrawer(MagicEither::Left(withdrawer)),
1972+
limits: QueryStakesLimits::default(),
1973+
},
1974+
(None, None) => QueryStakes::default(),
19701975
};
19711976

19721977
let response = send_request(

src/cli/node/with_node.rs

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -295,15 +295,8 @@ pub fn exec_cmd(
295295
node,
296296
validator,
297297
withdrawer,
298-
all,
299298
long,
300-
} => rpc::query_stakes(
301-
node.unwrap_or(default_jsonrpc),
302-
validator,
303-
withdrawer,
304-
all,
305-
long,
306-
),
299+
} => rpc::query_stakes(node.unwrap_or(default_jsonrpc), validator, withdrawer, long),
307300
Command::QueryPowers {
308301
node,
309302
capability,
@@ -840,8 +833,6 @@ pub enum Command {
840833
validator: Option<String>,
841834
#[structopt(short = "w", long = "withdrawer")]
842835
withdrawer: Option<String>,
843-
#[structopt(short = "a", long = "all")]
844-
all: bool,
845836
#[structopt(short = "l", long = "long")]
846837
long: bool,
847838
},

0 commit comments

Comments
 (0)