fix(validations): fix missing data request state in validations for instantaneous data requests (e.g., TooManyWitnesses)

Author: drcpu-github

node/src/actors/chain_manager/mod.rs

@@ -710,7 +710,7 @@ impl ChainManager {
                 rep_engine,
                 epoch_constants,
                 &self.chain_state.unspent_outputs_pool,
-                &self.chain_state.data_request_pool,
+                &mut self.chain_state.data_request_pool,
                 vrf_ctx,
                 block_number,
                 &chain_info.consensus_constants,
@@ -866,6 +866,7 @@ impl ChainManager {
                 // in this block candidate.
                 let mut transaction_visitor = PriorityVisitor::default();
 
+                let block_number = self.chain_state.block_number();
                 match process_validations(
                     &block,
                     current_epoch,
@@ -874,11 +875,11 @@ impl ChainManager {
                     rep_engine,
                     self.epoch_constants.unwrap(),
                     &self.chain_state.unspent_outputs_pool,
-                    &self.chain_state.data_request_pool,
+                    &mut self.chain_state.data_request_pool,
                     // The unwrap is safe because if there is no VRF context,
                     // the actor should have stopped execution
                     self.vrf_ctx.as_mut().expect("No initialized VRF context"),
-                    self.chain_state.block_number(),
+                    block_number,
                     &chain_info.consensus_constants,
                     false,
                     &active_wips,
@@ -2113,7 +2114,7 @@ impl ChainManager {
             let mut signatures_to_verify = vec![];
             let res = validate_block_transactions(
                 &act.chain_state.unspent_outputs_pool,
-                &act.chain_state.data_request_pool,
+                &mut act.chain_state.data_request_pool,
                 &block,
                 vrf_input,
                 &mut signatures_to_verify,
@@ -2892,7 +2893,7 @@ pub fn process_validations(
     rep_eng: &ReputationEngine,
     epoch_constants: EpochConstants,
     utxo_set: &UnspentOutputsPool,
-    dr_pool: &DataRequestPool,
+    dr_pool: &mut DataRequestPool,
     vrf_ctx: &mut VrfCtx,
     block_number: u32,
     consensus_constants: &ConsensusConstants,

validations/src/validations.rs

@@ -1675,7 +1675,7 @@ pub fn update_utxo_diff<'a, IterInputs, IterOutputs>(
 #[allow(clippy::too_many_arguments)]
 pub fn validate_block_transactions(
     utxo_set: &UnspentOutputsPool,
-    dr_pool: &DataRequestPool,
+    dr_pool: &mut DataRequestPool,
     block: &Block,
     vrf_input: CheckpointVRF,
     signatures_to_verify: &mut Vec<SignaturesToVerify>,
@@ -1845,6 +1845,30 @@ pub fn validate_block_transactions(
     }
     let re_hash_merkle_root = re_mt.root();
 
+    for transaction in &block.txns.data_request_txns {
+        let dr_tx_hash = transaction.hash();
+        if !dr_pool.data_request_pool.contains_key(&dr_tx_hash)
+            && data_request_has_too_many_witnesses(
+                &transaction.body.dr_output,
+                stakes.validator_count(),
+                Some(epoch),
+            )
+        {
+            log::debug!(
+                "Temporarily adding data request {} to data request pool for validation purposes",
+                transaction.hash()
+            );
+            if let Err(e) = dr_pool.process_data_request(transaction, epoch, &block.hash()) {
+                log::error!("Error adding data request to the data request pool: {}", e);
+            }
+            if let Some(dr_state) = dr_pool.data_request_state_mutable(&dr_tx_hash) {
+                dr_state.update_stage(0, true);
+            } else {
+                log::error!("Could not find data request state");
+            }
+        }
+    }
+
     // Validate tally transactions in a block
     let mut ta_mt = ProgressiveMerkleTree::sha256();
     let mut tally_hs = HashSet::with_capacity(block.txns.tally_txns.len());