From 1e00f322794854a7e7e8812293d2573513f45da7 Mon Sep 17 00:00:00 2001 From: matthuisman Date: Mon, 23 Jun 2025 10:10:48 +1200 Subject: [PATCH 1/2] remove encoding from wb open --- junitparser/junitparser.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/junitparser/junitparser.py b/junitparser/junitparser.py index bbf7046..74973e6 100644 --- a/junitparser/junitparser.py +++ b/junitparser/junitparser.py @@ -33,7 +33,7 @@ def write_xml(obj, file_or_filename: Optional[Union[str, IO]] = None, *, pretty: xml = parseString(text) # nosec content = xml.toprettyxml(encoding="utf-8") if isinstance(file_or_filename, str): - with open(file_or_filename, encoding="utf-8", mode="wb") as xmlfile: + with open(file_or_filename, mode="wb") as xmlfile: xmlfile.write(content) else: if isinstance(file_or_filename, io.TextIOWrapper): From 6034270d4dfb02d661d7edcbd21432ced20a7042 Mon Sep 17 00:00:00 2001 From: matthuisman Date: Mon, 23 Jun 2025 10:38:33 +1200 Subject: [PATCH 2/2] bump ver and changelog --- CHANGELOG.md | 4 ++++ junitparser/__init__.py | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7bd105f..e17b62d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Changelog +## [4.0.1] - 2025-06-23 +### Fixed +- `write_xml` - Remove encoding kwarg to fix `binary mode doesn't take an encoding argument` + ## [4.0.0] - 2025-06-22 ### Breaking - Renamed argument `filepath` of methods `write_xml`, `TestSuite.write`, and `JUnitXml.write` diff --git a/junitparser/__init__.py b/junitparser/__init__.py index 2282b95..0491244 100644 --- a/junitparser/__init__.py +++ b/junitparser/__init__.py @@ -16,7 +16,7 @@ TestSuite, ) -version = "4.0.0" +version = "4.0.1" __all__ = [ "Attr",