[4.0] ValueError: binary mode doesn't take an encoding argument

[matthuisman]

3.2.0...4.0.0#diff-34e52559794cd8046cb85853b982e8556424f6398d35ab1c24a98c9da67145b9R36

tests\test_tc.py:88: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
.envs\py310\venv\lib\site-packages\test_framework\testcase.py:1152: in run
    self._post_run()
.envs\py310\venv\lib\site-packages\test_framework\testcase.py:1305: in _post_run
    self._close_result()
.envs\py310\venv\lib\site-packages\test_framework\testcase.py:1314: in _close_result
    writer.test_finished(self)
.envs\py310\venv\lib\site-packages\test_framework\junit_xml_results_writer.py:181: in test_finished
    xmlwriter.write(xml_path, pretty=True)
.envs\py310\venv\lib\site-packages\junitparser\junitparser.py:791: in write
    write_xml(self, file_or_filename=file_or_filename, pretty=pretty)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

obj = <Element 'testsuites'>
file_or_filename = 'C:\\jenkins\\workspace\\TC.xml'

    def write_xml(obj, file_or_filename: Optional[Union[str, IO]] = None, *, pretty: bool = False):
        tree = etree.ElementTree(obj._elem)
        if file_or_filename is None:
            file_or_filename = obj.filepath
        if file_or_filename is None:
            raise JUnitXmlError("Missing file argument.")
    
        if pretty:
            from xml.dom.minidom import parseString
    
            text = etree.tostring(obj._elem)
            xml = parseString(text)  # nosec
            content = xml.toprettyxml(encoding="utf-8")
            if isinstance(file_or_filename, str):
>               with open(file_or_filename, encoding="utf-8", mode="wb") as xmlfile:
E               ValueError: binary mode doesn't take an encoding argument

.envs\py310\venv\lib\site-packages\junitparser\junitparser.py:36: ValueError

[matthuisman]

It also looks like you have uploaded a 3.2.0 whl therefore also breaking 3.2.0

[FlTr]

@EnricoMi this was already discussed in #162

[matthuisman]

@weiwei did you fix the 3.2.0?
I suspect your publish pipeline ran on a commit before you bumped the version.
So the 3.2.0 whl on pypi is actually the broken 4.0 code

UPDATE:
https://pypi.org/project/junitparser/3.2.0/#files
Looks like you have - thank you :)

[weiwei]

Yes @matthuisman

Thanks for the fix. Ping me if you see further issues.

[matthuisman]

Looking good our end with 4.0.1 - we just had to !=4.0 :)