Merge pull request #71 from webdoc-labs/fix/rest-object

Fix crash on rest element applied to object destructuring

Author: ShukantPal

packages/webdoc-parser/src/symbols-babel/build-symbol-tree.js

@@ -25,6 +25,7 @@ import {
   isIdentifier,
   isObjectMethod,
   isObjectPattern,
+  isRestElement,
   isScope,
   isVariableDeclaration,
 } from "@babel/types";
@@ -470,6 +471,14 @@ function registerObjectPropertyVariables(node: ObjectPattern): void {
   for (let i = 0, j = props.length; i < j; i++) {
     const prop = props[i];
 
+    if (isRestElement(prop)) {
+      continue;
+    }
+
+    if (!prop.key) {
+      throw new Error("WTF");
+    }
+
     declareVariable(prop.key.name);
 
     if (isObjectPattern(prop.value)) {

packages/webdoc-parser/test/lang-js.js

@@ -112,4 +112,12 @@ describe("@webdoc/parser.LanguageIntegration{@lang js}", function() {
     expect(symtree.members[0].meta.readonly).to.equal(true);
     expect(symtree.members[1].meta.readonly).to.not.equal(true);
   });
+
+  it("should not crash with rest object properties syntax", function() {
+    expect(
+      () => buildSymbolTree(`
+        const { a, b, ...rest } = globalThis;
+      `),
+    ).to.not.throw();
+  });
 });