From 7e3e1c6c5e7e0860fc71ff1ced2f17bb69e8be74 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 5 Dec 2025 22:30:44 +0000 Subject: [PATCH 1/3] Initial plan From a17e0eef758feb8545e3d63bdfa9f6b43bb7cc9d Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 5 Dec 2025 22:36:24 +0000 Subject: [PATCH 2/3] Replace macro-based header guard with pragma once Co-authored-by: wavefunction91 <6208701+wavefunction91@users.noreply.github.com> --- tests/collocation_common.hpp | 1 - tests/hdf5_test_serialization_impl.hpp | 5 +---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/collocation_common.hpp b/tests/collocation_common.hpp index a59ab07c..4e212101 100644 --- a/tests/collocation_common.hpp +++ b/tests/collocation_common.hpp @@ -22,7 +22,6 @@ using namespace GauXC; #define MAX_NPTS_CHECK 67 -#define REF_COLLOCATION_DATA_DEFINED // Guard for hdf5_test_serialization_impl.hpp struct ref_collocation_data { std::vector mask; diff --git a/tests/hdf5_test_serialization_impl.hpp b/tests/hdf5_test_serialization_impl.hpp index 5f1d4d30..d54a020b 100644 --- a/tests/hdf5_test_serialization_impl.hpp +++ b/tests/hdf5_test_serialization_impl.hpp @@ -12,10 +12,7 @@ #pragma once // This file contains implementations for HDF5 serialization of test data structures -// Must include struct definitions before this file -#ifndef REF_COLLOCATION_DATA_DEFINED -#error "collocation_common.hpp must be included before hdf5_test_serialization_impl.hpp" -#endif +// Must include collocation_common.hpp before this file to define ref_collocation_data and ref_weights_data #include "hdf5_test_serialization.hpp" From 5616c4c77dd25f75ca4c9de471c6873a1e6c26b7 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 5 Dec 2025 23:07:13 +0000 Subject: [PATCH 3/3] Include collocation_common.hpp directly in hdf5_test_serialization_impl.hpp Co-authored-by: wavefunction91 <6208701+wavefunction91@users.noreply.github.com> --- tests/hdf5_test_serialization_impl.hpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/hdf5_test_serialization_impl.hpp b/tests/hdf5_test_serialization_impl.hpp index d54a020b..99a0c70d 100644 --- a/tests/hdf5_test_serialization_impl.hpp +++ b/tests/hdf5_test_serialization_impl.hpp @@ -11,9 +11,7 @@ */ #pragma once -// This file contains implementations for HDF5 serialization of test data structures -// Must include collocation_common.hpp before this file to define ref_collocation_data and ref_weights_data - +#include "collocation_common.hpp" #include "hdf5_test_serialization.hpp" namespace GauXC {