From 9b0985f2343f088723842a3f16c1dbba13978b0b Mon Sep 17 00:00:00 2001 From: Anthony Pesce Date: Mon, 15 Sep 2025 15:58:08 -0400 Subject: [PATCH 1/3] chore: more fixes for the workflows --- .github/workflows/_release.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/_release.yml b/.github/workflows/_release.yml index b60dd621..efff2e4a 100644 --- a/.github/workflows/_release.yml +++ b/.github/workflows/_release.yml @@ -38,7 +38,7 @@ jobs: "libName": "libfastfec", "exeExt": "" }, - "mac": { + "macos": { "libExt": "dylib", "libName": "libfastfec", "exeExt": "" @@ -74,7 +74,6 @@ jobs: uses: actions/upload-artifact@v4 if: matrix.os != 'wasm' with: - overwrite: true name: fastfec-${{ matrix.os }}-${{ matrix.architecture }}-${{ inputs.version }} path: | fastfec-${{ matrix.os }}-${{ matrix.architecture }}-${{ inputs.version }}.zip @@ -83,7 +82,6 @@ jobs: uses: actions/upload-artifact@v4 if: matrix.os == 'wasm' with: - overwrite: true name: libfastfec-${{ matrix.os }}-${{ inputs.version }} path: | libfastfec-${{ inputs.version }}.${{ steps.map.outputs.libExt }} From d61afb9f8fb8f3734078d81973e3e93d9b9fd5b2 Mon Sep 17 00:00:00 2001 From: Anthony Pesce Date: Mon, 15 Sep 2025 16:04:52 -0400 Subject: [PATCH 2/3] chore: one more naming attempt --- .github/workflows/_release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/_release.yml b/.github/workflows/_release.yml index efff2e4a..850e3801 100644 --- a/.github/workflows/_release.yml +++ b/.github/workflows/_release.yml @@ -74,7 +74,7 @@ jobs: uses: actions/upload-artifact@v4 if: matrix.os != 'wasm' with: - name: fastfec-${{ matrix.os }}-${{ matrix.architecture }}-${{ inputs.version }} + name: fastfec-${{ matrix.os }}-${{ matrix.architecture }}-${{ inputs.version }}-${{ github.run_id }} path: | fastfec-${{ matrix.os }}-${{ matrix.architecture }}-${{ inputs.version }}.zip libfastfec-${{ matrix.os }}-${{ matrix.architecture }}-${{ inputs.version }}.${{ steps.map.outputs.libExt }} @@ -82,7 +82,7 @@ jobs: uses: actions/upload-artifact@v4 if: matrix.os == 'wasm' with: - name: libfastfec-${{ matrix.os }}-${{ inputs.version }} + name: libfastfec-${{ matrix.os }}-${{ inputs.version }}-${{ github.run_id }} path: | libfastfec-${{ inputs.version }}.${{ steps.map.outputs.libExt }} - name: GitHub release From 7cdc9b41585b07f34a550575ebb944e4a13bb7dc Mon Sep 17 00:00:00 2001 From: Anthony Pesce Date: Mon, 15 Sep 2025 16:11:13 -0400 Subject: [PATCH 3/3] chore: one more try --- .github/workflows/_python-wheels.yml | 6 +++--- .github/workflows/_release.yml | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/_python-wheels.yml b/.github/workflows/_python-wheels.yml index 44a0346d..0de47dbe 100644 --- a/.github/workflows/_python-wheels.yml +++ b/.github/workflows/_python-wheels.yml @@ -34,8 +34,7 @@ jobs: - uses: actions/upload-artifact@v4 with: - overwrite: true - name: wheels + name: wheels-${{ matrix.os }}-${{ matrix.architecture }} path: ./wheelhouse/*.whl upload-wheels-to-pypi: @@ -46,8 +45,9 @@ jobs: steps: - uses: actions/download-artifact@v4 with: - name: wheels + pattern: wheels-* path: dist + merge-multiple: true - name: Publish package to PyPI if: inputs.publishToPyPI diff --git a/.github/workflows/_release.yml b/.github/workflows/_release.yml index 850e3801..efff2e4a 100644 --- a/.github/workflows/_release.yml +++ b/.github/workflows/_release.yml @@ -74,7 +74,7 @@ jobs: uses: actions/upload-artifact@v4 if: matrix.os != 'wasm' with: - name: fastfec-${{ matrix.os }}-${{ matrix.architecture }}-${{ inputs.version }}-${{ github.run_id }} + name: fastfec-${{ matrix.os }}-${{ matrix.architecture }}-${{ inputs.version }} path: | fastfec-${{ matrix.os }}-${{ matrix.architecture }}-${{ inputs.version }}.zip libfastfec-${{ matrix.os }}-${{ matrix.architecture }}-${{ inputs.version }}.${{ steps.map.outputs.libExt }} @@ -82,7 +82,7 @@ jobs: uses: actions/upload-artifact@v4 if: matrix.os == 'wasm' with: - name: libfastfec-${{ matrix.os }}-${{ inputs.version }}-${{ github.run_id }} + name: libfastfec-${{ matrix.os }}-${{ inputs.version }} path: | libfastfec-${{ inputs.version }}.${{ steps.map.outputs.libExt }} - name: GitHub release