Skip to content

Updates deactivate timing for old EditContext #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dandclark merged 3 commits into from
Sep 5, 2025
Merged

Updates deactivate timing for old EditContext #117

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb7b93e
update deactivate timing
ashishkum-ms Sep 3, 2025
d3043e0
update steps to handle re-entracy
ashishkum-ms Sep 4, 2025
7c9f095
address formatting feedback
ashishkum-ms Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,23 +696,27 @@ <h3>Extensions to the HTMLElement interface</h3>
<ol>
<li>If |editContext|'s <a>associated element</a> is equal to [=this=], then terminate these steps.</li>
<li>If |editContext|'s <a>associated element</a> is not null, then [=exception/throw=] a {{"NotSupportedError"}} {{DOMException}}.</li>
<li>Set |editContext|'s <a>associated element</a> to [=this=].</li>
</ol>
</li>
<li>Let |oldEditContext| be the value of [=this=]'s internal [[\EditContext]] slot.</li>
<li>If |oldEditContext| is not null, then:
<ol>
<li>[=Assert=]: |oldEditContext|'s <a>associated element</a> is equal to [=this=].</li>
<li>Set |oldEditContext|'s <a>associated element</a> to null.</li>
</ol>
</li>
<li>Set [=this=]'s internal [[\EditContext]] slot to be |editContext|.</li>
<li>
If |oldEditContext| is not null and |oldEditContext| is [=this=]'s
<a href="https://dom.spec.whatwg.org/#concept-node-document">node document</a>'s
[=active EditContext=], then run the steps to [=deactivate an EditContext=]
with |oldEditContext|.
[=active EditContext=], then:
<ol>
<li>Run the steps to [=deactivate an EditContext=] with |oldEditContext|.</li>
<li>
If |oldEditContext|'s <a>associated element</a> is not equal to [=this=], then terminate these steps.
</li>
<li>
If |editContext| is not null, |editContext|'s <a>associated element</a> is not null and |editContext|'s
<a>associated element</a> is not equal to [=this=], then [=exception/throw=] a {{"NotSupportedError"}} {{DOMException}}.
</li>
</ol>
</li>
<li>If |oldEditContext| is not null, set |oldEditContext|'s <a>associated element</a> to null.</li>
<li>If |editContext| is not null, then set |editContext|'s <a>associated element</a> to [=this=].
<li>Set [=this=]'s internal [[\EditContext]] slot to be |editContext|.</li>
</ol>
</div><!-- algorithm -->
</dd>
Expand Down