refactor: improve test coverage

Author: kiaking

jest.config.js

@@ -17,6 +17,7 @@ module.exports = {
   coverageReporters: ['json', 'lcov', 'text-summary', 'clover'],
   collectCoverageFrom: [
     'src/**/*.ts',
+    '!src/index.ts',
     '!src/index.cjs.ts'
   ]
 }

src/connection/Connection.ts

@@ -52,15 +52,6 @@ export class Connection {
     return this.get()[id] ?? null
   }
 
-  /**
-   * Find multiple models by their index ids.
-   */
-  findIn(ids: string[]): Element[] {
-    const data = this.get()
-
-    return ids.map((id) => data[id])
-  }
-
   /**
    * Commit `insert` mutation to the store.
    */

src/model/attributes/relations/BelongsTo.ts

@@ -97,11 +97,4 @@ export class BelongsTo extends Relation {
         : model.$setRelation(relation, null)
     })
   }
-
-  /**
-   * Make the value for the attribute.
-   */
-  make(_value: any): null {
-    return null
-  }
 }

src/model/attributes/relations/HasMany.ts

@@ -81,11 +81,4 @@ export class HasMany extends Relation {
       return [result[this.foreignKey], result]
     })
   }
-
-  /**
-   * Make the value for the attribute.
-   */
-  make(_value: any): null {
-    return null
-  }
 }

src/model/attributes/relations/HasOne.ts

@@ -81,11 +81,4 @@ export class HasOne extends Relation {
       return [result[this.foreignKey], result]
     })
   }
-
-  /**
-   * Make the value for the attribute.
-   */
-  make(_value: any): null {
-    return null
-  }
 }

src/model/attributes/relations/Relation.ts

@@ -98,4 +98,12 @@ export abstract class Relation extends Attribute {
       return dictionary
     }, {})
   }
+
+  /**
+   * Make the value for the attribute.
+   */
+  /* istanbul ignore next */
+  make(_value: any): null {
+    return null
+  }
 }

src/query/Query.ts

@@ -238,25 +238,12 @@ export class Query<M extends Model = Model> {
   /**
    * Get models by given index ids.
    */
-  protected pick(id: string): Item<M>
-  protected pick(ids: string[]): Collection<M>
-  protected pick(ids: any): any {
-    if (isArray(ids)) {
-      return this.pickIn(ids)
-    }
-
-    const record = this.connection.find(ids)
+  protected pick(id: string): Item<M> {
+    const record = this.connection.find(id)
 
     return record ? this.hydrate(record) : null
   }
 
-  /**
-   * Get models by given index ids.
-   */
-  protected pickIn(ids: string[]): Collection<M> {
-    return this.hydrate(this.connection.findIn(ids))
-  }
-
   /**
    * Retrieve models by processing all filters set to the query chain.
    */