puppet-lint: fix legacy_facts

Author: bastelfreak

manifests/init.pp

@@ -73,7 +73,7 @@
   # Module compatibility check
   $compatible = [ 'Debian', 'RedHat', 'Suse', 'Gentoo', 'AIX' ]
   if ! ($facts['os']['family'] in $compatible) {
-    fail("Module is not compatible with ${::operatingsystem}")
+    fail("Module is not compatible with ${facts['os']['name']}")
   }
 
   # Anchor pattern to contain dependencies

manifests/install.pp

@@ -145,9 +145,9 @@
     'rhscl': {
       # rhscl is RedHat SCLs from softwarecollections.org
       if $python::rhscl_use_public_repository {
-        $scl_package = "rhscl-${python::version}-epel-${::operatingsystemmajrelease}-${::architecture}"
+        $scl_package = "rhscl-${python::version}-epel-${facts['os']['release']['major']}-${facts['os']['architecture']}"
         package { $scl_package:
-          source   => "https://www.softwarecollections.org/en/scls/rhscl/${python::version}/epel-${::operatingsystemmajrelease}-${::architecture}/download/${scl_package}.noarch.rpm",
+          source   => "https://www.softwarecollections.org/en/scls/rhscl/${python::version}/epel-${facts['os']['release']['major']}-${facts['os']['architecture']}/download/${scl_package}.noarch.rpm",
           provider => 'rpm',
           tag      => 'python-scl-repo',
         }
@@ -244,7 +244,7 @@
               Class['epel'] -> Package['pip']
             }
           }
-          if ($venv_ensure != 'absent') and ($::operatingsystemrelease =~ /^6/) {
+          if ($venv_ensure != 'absent') and ($facts['os']['release']['full'] =~ /^6/) {
             if $python::use_epel == true {
               include 'epel'
               Class['epel'] -> Package['virtualenv']
@@ -272,11 +272,11 @@
         $pip_category = undef
         $pip_package = "${python}-pip"
         $pip_provider = $python.regsubst(/^.*python3\.?/,'pip3.').regsubst(/\.$/,'')
-      } elsif ($::osfamily == 'RedHat') and (versioncmp($::operatingsystemmajrelease, '7') >= 0) {
+      } elsif ($facts['os']['family'] == 'RedHat') and (versioncmp($facts['os']['release']['major'], '7') >= 0) {
         $pip_category = undef
         $pip_package = 'python2-pip'
         $pip_provider = pip2
-      } elsif $::osfamily == 'Gentoo' {
+      } elsif $facts['os']['family'] == 'Gentoo' {
         $pip_category = 'dev-python'
         $pip_package = 'pip'
         $pip_provider = 'pip'

manifests/params.pp

@@ -15,8 +15,8 @@
   $valid_versions         = undef
   $manage_scl             = true
 
-  if $::osfamily == 'RedHat' {
-    if $::operatingsystem != 'Fedora' {
+  if $facts['os']['family'] == 'RedHat' {
+    if $facts['os']['name'] != 'Fedora' {
       $use_epel           = true
     } else {
       $use_epel           = false

manifests/pyvenv.pp

@@ -46,7 +46,7 @@
     # Debian splits the venv module into a seperate package
     if ( $facts['os']['family'] == 'Debian'){
       $python3_venv_package="python${normalized_python_version}-venv"
-      case $facts['lsbdistcodename'] {
+      case $facts['os']['distro']['codename'] {
         'xenial','bionic','cosmic','disco',
         'jessie','stretch','buster': {
           ensure_packages ($python3_venv_package)