macos-intel-10.13 and ios-12.0 compat

Author: smanolloff

.github/workflows/rebuildDependencies.yml

@@ -143,6 +143,7 @@ jobs:
         git sparse-checkout set \
           recipes/minizip \
           recipes/flac \
+          recipes/onnx \
           recipes/onnxruntime \
           $recipePathQt \
 
@@ -154,15 +155,15 @@ jobs:
 
         # versions must be synced with: conan_patches/<package>/conandata.yml
         # if no custom patches are required for a package, it should be removed from here
-        for p in minizip/1.3.1 flac/1.4.2 onnxruntime/1.18.1 ; do
+        for p in minizip/1.3.1 flac/1.4.2 onnx/1.16.2 onnxruntime/1.18.1 ; do
           IFS_OLD="$IFS"
           IFS=/
           read package version <<<"$p"
           IFS="$IFS_OLD"
 
           if [[ $package == qt ]] ; then
             packagePath="$recipePathQt/5.x.x"
-          elif [[ $package == onnxruntime ]] && ${{ contains(matrix.conan_options, 'with_onnxruntime=False') }} ; then
+          elif [[ $package =~ ^onnx ]] && ${{ contains(matrix.conan_options, 'with_onnxruntime=False') }} ; then
             continue
           else
             packagePath="recipes/$package/all"

conan_patches/onnx/conandata.yml

@@ -0,0 +1,7 @@
+patches:
+  "1.16.2":
+    - patch_file: "patches/apple-pre-2019.diff"
+      patch_description: |
+        Fixes errors for older apple targets:
+        error: 'basic_fstream' is unavailable: introduced in macOS 10.15
+        error: 'basic_fstream' is unavailable: introduced in iOS 13.0

conan_patches/onnx/patches/apple-pre-2019.diff

@@ -0,0 +1,12 @@
+--- a/onnx/common/file_utils.h
++++ b/onnx/common/file_utils.h
+@@ -17,8 +17,7 @@ namespace ONNX_NAMESPACE {
+ 
+ template <typename T>
+ void LoadProtoFromPath(const std::string proto_path, T& proto) {
+-  std::filesystem::path proto_u8_path = std::filesystem::u8path(proto_path);
+-  std::fstream proto_stream(proto_u8_path, std::ios::in | std::ios::binary);
++  std::fstream proto_stream(proto_path, std::ios::in | std::ios::binary);
+   if (!proto_stream.good()) {
+     fail_check("Unable to open proto file: ", proto_path, ". Please check if it is a valid proto. ");
+   }

conan_profiles/ios-arm64

@@ -1,5 +1,5 @@
 include(base/ios)
 
 [settings]
-os.version=13.0
+os.version=12.0
 arch=armv8

conan_profiles/macos-intel

@@ -1,5 +1,5 @@
 include(base/macos)
 
 [settings]
-os.version=10.15
+os.version=10.13
 arch=x86_64