JSON.net Assemblies file appears to be missing

[jyearley]

The Readme mentions that an asset package had been included (and a "JSON.Net Assemblies" file) in the project to extract the needed JSON.net version, though that file appears to not be included.

Realize that this repo has moved into the ADL account, though that repo doesn't have an "Issues" tab on it, and it didn't appear to have the asset package or file either.

[Giantbean]

Still no "JSON.Net Assemblies" file here or in the forked ADL account with no issue tracker. Please advise.

[vbhayden]

Misread the issue initially and assumed it was talking about an asmdef, checking now for where the unity package ended up.

[vbhayden]

@jyearley thanks for bringing this up, sorry for the delay + misread
@Giantbean thanks for the bump

Should be fixed in with #3

[Giantbean]

Thank you this now gives errors

Assets\Unity-xAPI-Wrapper-master\Editor\ConfigObjectInspector.cs(35,29): error CS1501: No overload for method 'Space' takes 1 arguments

This pops up 4 times in the ConfigObjectInspector.cs

Edit:
GUILayout.Space(20); will add 20 pixels but for EditorGUILayout.Space(); the pixels should be predefined. Will removing the "Editor" be an issue here?

Edit 2:
Tested removing the "Editor" or the "20" form EditorGUILayout.Space(20); and I have many missing Mono Behaviors in the Buttons Demo either way?

[vbhayden]

Looks like there were a few issues with the .meta files, I'll look at this after work.

[Giantbean]

Did you get the meta files sorted out? Should I open a new issue for these compile errors and broken meta data?

[vbhayden]

Afternoon guys,

The example and whatnot should all be resolved + merged now. Last week ended up being a bit longer than expected, so I didn't have much mental bandwidth during off-hours.

For the example, I checked and things seem to be working fine now -- even with newer versions of Unity apparently importing Newtonsoft's JSON library automatically.

Let me know if anything else seems odd.

[Giantbean]

I'm still getting Assets\Unity-xAPI-Wrapper-master\Editor\ConfigObjectInspector.cs(35,29): error CS1501: No overload for method 'Space' takes 1 arguments in older versions of Unity but not in a 2020 version. Any suggestion for use with Unity 2018 to add xAPI to an old project?

[vbhayden]

Whoops forgot that the Space thing was an issue, should be fixed now

c210e07

[Giantbean]

I had to rebuild the buttons in 2018 but I Got it working! Thank you so much! I would say the issue can be closed.

[jyearley]

Hey there! Would you be able to merge this project with the ADL project? [https://github.com/adlnet/Unity-xAPI-Wrapper] That is the project that I refer others to when sharing with others interested in xAPI reporting to an LRS and using Unity. As it's the one that's the most straightforward, and a part of ADL. And it reads "This branch is 5 commits behind vbhayden:master."

Thank you for reading, keeping the project updated, and understanding!