Implement new repository settings (#1216)

Author: speedywizard

lib/travis/api/v3/models/user_settings.rb

@@ -10,6 +10,8 @@ class Models::UserSettings < Models::JsonSlice
     attribute :auto_cancel_pull_requests, Boolean, default: lambda { |us, _| us.auto_cancel_default? }
     attribute :allow_config_imports, Boolean, default: false
     attribute :config_validation, Boolean, default: lambda { |us, _| us.config_validation? }
+    attribute :share_encrypted_env_with_forks, Boolean, default: false
+    attribute :share_ssh_keys_with_forks, Boolean, default: lambda { |us, _| us.share_ssh_keys_with_forks? }
 
     attr_reader :repo
 
@@ -34,6 +36,12 @@ def config_validation?
       new_repo? || old_repo?
     end
 
+    def share_ssh_keys_with_forks?
+      return false unless ENV['IBM_REPO_SWITCHES_DATE']
+
+      repo.created_at <= Date.parse(ENV['IBM_REPO_SWITCHES_DATE'])
+    end
+
     def new_repo?
       repo.created_at >= NOV_15
     end

lib/travis/model/repository.rb

@@ -183,6 +183,7 @@ def regenerate_key!
   def settings
     @settings ||= begin
       instance = Repository::Settings.load(super, repository_id: id)
+      instance.handle_ssh_share(id)
       instance.on_save do
         self.settings = instance.to_json
         self.save!

lib/travis/model/repository/settings.rb

@@ -99,6 +99,8 @@ def custom_timeouts?(settings)
   attribute :auto_cancel_pushes, Boolean, default: lambda { |s, _| s.auto_cancel_default? }
   attribute :auto_cancel_pull_requests, Boolean, default: lambda { |s, _| s.auto_cancel_default? }
   attribute :allow_config_imports, Boolean, default: false
+  attribute :share_encrypted_env_with_forks, Boolean, default: false
+  attribute :share_ssh_keys_with_forks, Boolean, default: nil
 
   validates :maximum_number_of_builds, numericality: true
 
@@ -147,6 +149,17 @@ def repository_id
   def repository
     Repository.find(repository_id)
   end
+
+  def handle_ssh_share(id)
+    if self.share_ssh_keys_with_forks.nil?
+      self.share_ssh_keys_with_forks = false
+      return unless ENV['IBM_REPO_SWITCHES_DATE']
+
+       repo = Repository.find(id)
+       self.share_ssh_keys_with_forks = repo.created_at <= Date.parse(ENV['IBM_REPO_SWITCHES_DATE']) if repo
+
+    end
+  end
 end
 
 class Repository::DefaultSettings < Repository::Settings

spec/lib/model/repository_spec.rb

@@ -358,21 +358,6 @@
       expect(repo.settings.build_pushes?).to be true
     end
 
-    it "allows to set nil for settings" do
-      repo.settings = nil
-      expect(repo.settings.to_hash).to eq(Repository::Settings.new.to_hash)
-    end
-
-    it "allows to set settings as JSON string" do
-      repo.settings = '{"maximum_number_of_builds": 44}'
-      expect(repo.settings.to_hash).to eq(Repository::Settings.new(maximum_number_of_builds: 44).to_hash)
-    end
-
-    it "allows to set settings as a Hash" do
-      repo.settings = { maximum_number_of_builds: 44}
-      expect(repo.settings.to_hash).to eq(Repository::Settings.new(maximum_number_of_builds: 44).to_hash)
-    end
-
     it 'updates settings in the DB' do
       repo.settings = {'build_pushes' => false}
       repo.save

spec/v3/services/user_setting/find_spec.rb

@@ -99,4 +99,62 @@
       )
     end
   end
+
+  describe 'authenticated, existing repo, default share_encrypted_env_with_forks setting' do
+    before do
+      get("/v3/repo/#{repo.id}/setting/share_encrypted_env_with_forks", {}, auth_headers)
+    end
+
+    example { expect(last_response.status).to eq(200) }
+    example do
+      expect(JSON.load(body)).to eq(
+        '@type' => 'setting',
+        '@representation' => 'standard',
+        '@permissions' => { 'read' => true, 'write' => false },
+        '@href' => "/v3/repo/#{repo.id}/setting/share_encrypted_env_with_forks",
+        'name' => 'share_encrypted_env_with_forks',
+        'value' => false
+      )
+    end
+  end
+
+  describe 'authenticated, existing repo, default share_ssh_keys_with_forks setting' do
+    let(:created_at) { Date.parse('2021-09-01') }
+
+    before do
+      ENV['IBM_REPO_SWITCHES_DATE'] = '2021-10-01'
+      repo.update(created_at: created_at)
+      get("/v3/repo/#{repo.id}/setting/share_ssh_keys_with_forks", {}, auth_headers)
+    end
+
+    after { ENV['IBM_REPO_SWITCHES_DATE'] = nil }
+
+    example { expect(last_response.status).to eq(200) }
+    example do
+      expect(JSON.load(body)).to eq(
+        '@type' => 'setting',
+        '@representation' => 'standard',
+        '@permissions' => { 'read' => true, 'write' => false },
+        '@href' => "/v3/repo/#{repo.id}/setting/share_ssh_keys_with_forks",
+        'name' => 'share_ssh_keys_with_forks',
+        'value' => true
+      )
+    end
+
+    context 'when repo is new' do
+      let(:created_at) { Date.parse('2021-11-01') }
+
+      example { expect(last_response.status).to eq(200) }
+      example do
+        expect(JSON.load(body)).to eq(
+          '@type' => 'setting',
+          '@representation' => 'standard',
+          '@permissions' => { 'read' => true, 'write' => false },
+          '@href' => "/v3/repo/#{repo.id}/setting/share_ssh_keys_with_forks",
+          'name' => 'share_ssh_keys_with_forks',
+          'value' => false
+        )
+      end
+    end
+  end
 end

spec/v3/services/user_settings/for_repository_spec.rb

@@ -49,6 +49,8 @@
             { '@type' => 'setting', '@href' => "/v3/repo/#{repo.id}/setting/auto_cancel_pushes",          '@representation' => 'standard', '@permissions' => { 'read' => true, 'write' => true }, 'name' => 'auto_cancel_pushes',          'value' => false },
             { '@type' => 'setting', '@href' => "/v3/repo/#{repo.id}/setting/auto_cancel_pull_requests",   '@representation' => 'standard', '@permissions' => { 'read' => true, 'write' => true }, 'name' => 'auto_cancel_pull_requests',   'value' => false },
             { '@type' => 'setting', '@href' => "/v3/repo/#{repo.id}/setting/config_validation",           '@representation' => 'standard', '@permissions' => { 'read' => true, 'write' => true }, 'name' => 'config_validation',           'value' => false },
+            { '@type' => 'setting', '@href' => "/v3/repo/#{repo.id}/setting/share_encrypted_env_with_forks",           '@representation' => 'standard', '@permissions' => { 'read' => true, 'write' => true }, 'name' => 'share_encrypted_env_with_forks',           'value' => false },
+            { '@type' => 'setting', '@href' => "/v3/repo/#{repo.id}/setting/share_ssh_keys_with_forks",           '@representation' => 'standard', '@permissions' => { 'read' => true, 'write' => true }, 'name' => 'share_ssh_keys_with_forks',           'value' => false },
           ]
         )
       end
@@ -86,6 +88,8 @@
           { '@type' => 'setting', '@href' => "/v3/repo/#{repo.id}/setting/auto_cancel_pushes",          '@representation' => 'standard', '@permissions' => { 'read' => true, 'write' => true }, 'name' => 'auto_cancel_pushes',          'value' => false },
           { '@type' => 'setting', '@href' => "/v3/repo/#{repo.id}/setting/auto_cancel_pull_requests",   '@representation' => 'standard', '@permissions' => { 'read' => true, 'write' => true }, 'name' => 'auto_cancel_pull_requests',   'value' => false },
           { '@type' => 'setting', '@href' => "/v3/repo/#{repo.id}/setting/config_validation",           '@representation' => 'standard', '@permissions' => { 'read' => true, 'write' => true }, 'name' => 'config_validation',           'value' => false },
+          { '@type' => 'setting', '@href' => "/v3/repo/#{repo.id}/setting/share_encrypted_env_with_forks",           '@representation' => 'standard', '@permissions' => { 'read' => true, 'write' => true }, 'name' => 'share_encrypted_env_with_forks',           'value' => false },
+          { '@type' => 'setting', '@href' => "/v3/repo/#{repo.id}/setting/share_ssh_keys_with_forks",           '@representation' => 'standard', '@permissions' => { 'read' => true, 'write' => true }, 'name' => 'share_ssh_keys_with_forks',           'value' => false },
         ]
       )
     end
@@ -110,4 +114,4 @@
       )
     end
   end
-end
+end