Skip to content

Commit fa038dc

Browse files
committed
chore: don't test against the latest version of the plugins over http on CI
It will fail the CI when we change the WIT interfaces, even though we have green test. Renamed the task `test-e2e-pluginlab-http` to `test-e2e-pluginlab-http-latest` that should be run in local to check if you have breaking changes
1 parent 6e134bf commit fa038dc

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

.github/workflows/rust-host.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ jobs:
4141
run: just build
4242
- name: Test
4343
run: just test
44-
- name: Test with wasm from http server (if it fails, you need to publish a new version of pluginlab)
45-
run: just test-e2e-pluginlab-http
4644

4745
- name: Build plugins in release mode (for release-draft)
4846
if: github.ref_type == 'tag'

README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,9 @@ just test
253253
```
254254

255255
```bash
256-
# Runs e2e tests on the REPL using the plugins from the http server
257-
just test-e2e-pluginlab-http
256+
# Runs e2e tests on the REPL against the latest version of the plugins available at https://topheman.github.io/webassembly-component-model-experiments/plugins
257+
# Launch to check for breaking changes with the WIT interface
258+
just test-e2e-pluginlab-http-latest
258259
```
259260

260261
#### Make a rust plugin

justfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,12 +141,12 @@ test-e2e-pluginlab: build-repl-logic-guest build-plugins prepare-fixtures
141141
test-e2e-pluginlab-nocapture: build-repl-logic-guest build-plugins prepare-fixtures
142142
cargo test -p pluginlab -- --nocapture
143143

144-
# Run the e2e tests for the pluginlab retrieving the plugins from the HTTP server
145-
test-e2e-pluginlab-http: build-repl-logic-guest build-plugins prepare-fixtures
144+
# Run the e2e tests for the pluginlab retrieving the plugins from the HTTP server - launch to check for breaking changes
145+
test-e2e-pluginlab-http-latest: build-repl-logic-guest build-plugins prepare-fixtures
146146
WASM_TARGET_DIR=https://topheman.github.io/webassembly-component-model-experiments/plugins cargo test -p pluginlab
147147

148-
# Run the e2e tests for the pluginlab retrieving the plugins from the HTTP server
149-
test-e2e-pluginlab-http-nocapture: build-repl-logic-guest build-plugins prepare-fixtures
148+
# Run the e2e tests for the pluginlab retrieving the plugins from the HTTP server - launch to check for breaking changes
149+
test-e2e-pluginlab-http-latest-nocapture: build-repl-logic-guest build-plugins prepare-fixtures
150150
WASM_TARGET_DIR=https://topheman.github.io/webassembly-component-model-experiments/plugins cargo test -p pluginlab -- --nocapture
151151

152152
# Prepare the fixtures for the e2e tests

0 commit comments

Comments
 (0)