feat: Using the /health endpoint for validation

vlastahajek · vlastahajek · commit b63dfe6dda21 · 2020-07-01T14:43:05.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 ## Version 3.3.0 (in progress)
  - [NEW] Added possibility skip server certification validation (`setInsecure()` method)
  - [NEW] Added possibility to query flux on InfuxDB 1.8 using V1 approach
+ - [NEW] `validateConnection()` can be used also for the [forward compatibility](https://docs.influxdata.com/influxdb/latest/tools/api/#influxdb-2-0-api-compatibility-endpoints) connection to InfluxDB 1.8
  - [FIX] Debug compilation error
  - [FIX] SecureBatchWrite compile error
  
diff --git a/src/InfluxDbClient.cpp b/src/InfluxDbClient.cpp
@@ -508,7 +508,7 @@ bool InfluxDBClient::validateConnection() {
         return false;
     }
     // on version 1.x /ping will by default return status code 204, without verbose
-    String url = _serverUrl + (_dbVersion==2?"/ready":"/ping?verbose=true");
+    String url = _serverUrl + (_dbVersion==2?"/health":"/ping?verbose=true");
     INFLUXDB_CLIENT_DEBUG("[D] Validating connection to %s\n", url.c_str());
 
     if(!_httpClient.begin(*_wifiClient, url)) {
diff --git a/test/server/server.js b/test/server/server.js
@@ -27,6 +27,10 @@ app.get('/ready', (req,res) => {
     lastUserAgent = req.get('User-Agent');
     res.status(200).send("<html><body><h1>OK</h1></body></html>");
 })
+app.get('/health', (req,res) => {
+    lastUserAgent = req.get('User-Agent');
+    res.status(200).send("<html><body><h1>OK</h1></body></html>");
+})
 
 app.get('/ping', (req,res) => {
     lastUserAgent = req.get('User-Agent');
diff --git a/test/test.ino b/test/test.ino
@@ -48,7 +48,7 @@ void setup() {
 }
 
 void loop() {
-    //tests
+    // Basic tests
     testPoint();
     testFluxTypes();
     testFluxParserEmpty();
@@ -66,6 +66,7 @@ void loop() {
     testInit();
     testV1();
     testUserAgent();
+    // Advanced tests
     testFailedWrites();
     testTimestamp();
     testRetryOnFailedConnection();

Original file line number	Diff line number	Diff line change
`@@ -508,7 +508,7 @@ bool InfluxDBClient::validateConnection() {`
`508`	`508`	`return false;`
`509`	`509`	`}`
`510`	`510`	`// on version 1.x /ping will by default return status code 204, without verbose`
`511`		`- String url = _serverUrl + (_dbVersion==2?"/ready":"/ping?verbose=true");`
	`511`	`+ String url = _serverUrl + (_dbVersion==2?"/health":"/ping?verbose=true");`
`512`	`512`	`INFLUXDB_CLIENT_DEBUG("[D] Validating connection to %s\n", url.c_str());`
`513`	`513`
`514`	`514`	`if(!_httpClient.begin(*_wifiClient, url)) {`