tests(Pane,Window): Use direction in .split()

Author: tony

tests/legacy_api/test_window.py

@@ -159,6 +159,7 @@ def test_split_window_horizontal(session: Session) -> None:
 
 
 @pytest.mark.filterwarnings("ignore:.*deprecated in favor of Window.split()")
+@pytest.mark.filterwarnings("ignore:.*vertical is not required to pass with direction.")
 def test_split_percentage(
     session: Session,
 ) -> None:
@@ -178,6 +179,37 @@ def test_split_percentage(
         assert pane.pane_height == str(int(window_height_before * 0.1))
 
 
+def test_split_window_size(session: Session) -> None:
+    """Window.split_window() respects size."""
+    window = session.new_window(window_name="split_window window size")
+    window.resize(height=100, width=100)
+
+    if has_gte_version("3.1"):
+        pane = window.split_window(size=10)
+        assert pane.pane_height == "10"
+
+        pane = window.split_window(vertical=False, size=10)
+        assert pane.pane_width == "10"
+
+        pane = window.split_window(size="10%")
+        assert pane.pane_height == "8"
+
+        pane = window.split_window(vertical=False, size="10%")
+        assert pane.pane_width == "8"
+    else:
+        window_height_before = (
+            int(window.window_height) if isinstance(window.window_height, str) else 0
+        )
+        window_width_before = (
+            int(window.window_width) if isinstance(window.window_width, str) else 0
+        )
+        pane = window.split_window(size="10%")
+        assert pane.pane_height == str(int(window_height_before * 0.1))
+
+        pane = window.split_window(vertical=False, size="10%")
+        assert pane.pane_width == str(int(window_width_before * 0.1))
+
+
 @pytest.mark.parametrize(
     "window_name_before,window_name_after",
     [("test", "ha ha ha fjewlkjflwef"), ("test", "hello \\ wazzup 0")],

tests/test_pane.py

@@ -6,7 +6,7 @@
 import pytest
 
 from libtmux.common import has_gte_version, has_lt_version
-from libtmux.constants import ResizeAdjustmentDirection
+from libtmux.constants import PaneDirection, ResizeAdjustmentDirection
 from libtmux.session import Session
 
 logger = logging.getLogger(__name__)
@@ -145,7 +145,7 @@ def test_resize_pane(
 
     window = session.active_window
     pane = window.split(attach=False)
-    window.split(vertical=True, attach=False)
+    window.split(direction=PaneDirection.Above, attach=False)
 
     assert pane is not None
 
@@ -236,13 +236,13 @@ def test_split_pane_size(session: Session) -> None:
         short_pane = pane.split(size=10)
         assert short_pane.pane_height == "10"
 
-        narrow_pane = pane.split(vertical=False, size=10)
+        narrow_pane = pane.split(direction=PaneDirection.Right, size=10)
         assert narrow_pane.pane_width == "10"
 
         new_pane = pane.split(size="10%")
         assert new_pane.pane_height == "8"
 
-        new_pane = short_pane.split(vertical=False, size="10%")
+        new_pane = short_pane.split(direction=PaneDirection.Right, size="10%")
         assert new_pane.pane_width == "10"
     else:
         window_height_before = (
@@ -254,5 +254,5 @@ def test_split_pane_size(session: Session) -> None:
         new_pane = pane.split(size="10%")
         assert new_pane.pane_height == str(int(window_height_before * 0.1))
 
-        new_pane = new_pane.split(vertical=False, size="10%")
+        new_pane = new_pane.split(direction=PaneDirection.Right, size="10%")
         assert new_pane.pane_width == str(int(window_width_before * 0.1))

tests/test_window.py

@@ -10,7 +10,11 @@
 from libtmux import exc
 from libtmux._internal.query_list import ObjectDoesNotExist
 from libtmux.common import has_gte_version, has_lt_version
-from libtmux.constants import ResizeAdjustmentDirection, WindowDirection
+from libtmux.constants import (
+    PaneDirection,
+    ResizeAdjustmentDirection,
+    WindowDirection,
+)
 from libtmux.pane import Pane
 from libtmux.server import Server
 from libtmux.session import Session
@@ -160,7 +164,7 @@ def test_split_horizontal(session: Session) -> None:
     """Window.split() splits window, returns new Pane, horizontal."""
     window_name = "test split window"
     window = session.new_window(window_name=window_name, attach=True)
-    pane = window.split(vertical=False)
+    pane = window.split(direction=PaneDirection.Right)
     assert len(window.panes) == 2
     assert isinstance(pane, Pane)
 
@@ -181,13 +185,13 @@ def test_split_size(session: Session) -> None:
         pane = window.split(size=10)
         assert pane.pane_height == "10"
 
-        pane = window.split(vertical=False, size=10)
+        pane = window.split(direction=PaneDirection.Right, size=10)
         assert pane.pane_width == "10"
 
         pane = window.split(size="10%")
         assert pane.pane_height == "8"
 
-        pane = window.split(vertical=False, size="10%")
+        pane = window.split(direction=PaneDirection.Right, size="10%")
         assert pane.pane_width == "8"
     else:
         window_height_before = (
@@ -199,7 +203,7 @@ def test_split_size(session: Session) -> None:
         pane = window.split(size="10%")
         assert pane.pane_height == str(int(window_height_before * 0.1))
 
-        pane = window.split(vertical=False, size="10%")
+        pane = window.split(direction=PaneDirection.Right, size="10%")
         assert pane.pane_width == str(int(window_width_before * 0.1))