Don't strip classes in Geom$use_defaults() (#5657)

* Use `vec_cbind()` instead of data.frame assignment

* ignore rownames in test

* Add test for AsIs class

Author: teunbrand

R/geom-.R

@@ -173,8 +173,7 @@ Geom <- ggproto("Geom",
     # Override mappings with params
     aes_params <- intersect(self$aesthetics(), names(params))
     check_aesthetics(params[aes_params], nrow(data))
-    data[aes_params] <- params[aes_params]
-    data
+    vec_cbind(data[setdiff(names(data), aes_params)], !!!params[aes_params])
   },
 
   # Most parameters for the geom are taken automatically from draw_panel() or

tests/testthat/test-geom-smooth.R

@@ -4,7 +4,7 @@ test_that("data is ordered by x", {
   ps <- ggplot(df, aes(x, y))+
     geom_smooth(stat = "identity", se = FALSE)
 
-  expect_equal(layer_data(ps)[c("x", "y")], df[order(df$x), ])
+  expect_equal(layer_data(ps)[c("x", "y")], df[order(df$x), ], ignore_attr = TRUE)
 })
 
 test_that("geom_smooth works in both directions", {

tests/testthat/test-layer.R

@@ -140,6 +140,19 @@ test_that("layer warns for constant aesthetics", {
 
 # Data extraction ---------------------------------------------------------
 
+test_that("AsIs data passes unmodified", {
+  p <- ggplot() + geom_blank(aes(x = 1:2, y = 1:2))
+  ld <- layer_data(p + geom_point(aes(x = I(0.5), y = I(0.5))), 2)
+  expect_s3_class(ld$x, "AsIs")
+  expect_equal(ld$y, I(0.5))
+  ld <- layer_data(p + geom_point(x = I(0.5), y = I(0.5), data = mtcars), 2)
+  expect_s3_class(ld$x, "AsIs")
+  expect_equal(ld$y[1], I(0.5))
+  ld <- layer_data(p + annotate("point", x = I(0.5), y = I(0.5)), 2)
+  expect_s3_class(ld$x, "AsIs")
+  expect_equal(ld$y, I(0.5))
+})
+
 test_that("layer_data returns a data.frame", {
   l <- geom_point()
   expect_equal(l$layer_data(mtcars), unrowname(mtcars))