Skip to content

Added not found exception #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptuchik wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added not found exception #187

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8706c3
Added not found exception
ptuchik May 25, 2018
db7b59f
Added new line at the end of the file
ptuchik May 25, 2018
13a5dcb
Error code changed to 0
ptuchik May 25, 2018
75c2ff6
NotFoundException renamed to ResourceNotFounException
ptuchik May 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/Common/Exception/NotFoundException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?php

namespace Omnipay\Common\Exception;

/**
* Not Found Exception
*
* Thrown when the requested resource is not found on payment gateway
*/
class NotFoundException extends \Exception implements OmnipayException
{
public function __construct($message = "Resource not found on payment gateway", $code = 404, $previous = null)
Copy link
Member

@barryvdh barryvdh May 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code can be just 0

Copy link
Author

@ptuchik ptuchik May 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to change or 404 is also OK?

Copy link
Author

@ptuchik ptuchik May 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to 0

Copy link
Member

@barryvdh barryvdh May 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to 0

{
parent::__construct($message, $code, $previous);
}
}