Skip to content

Commit cc5949e

Browse files
kendalharlandkendal
andcommitted
Explicitly set HAVE_IOCTLSOCKET_FIONBIO=1 (#30)
Co-authored-by: kendal <kendal@thebrowser.company>
1 parent a8f3e1e commit cc5949e

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

.github/workflows/bcny-firebase.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,9 @@ jobs:
5959
- name: Adjust cmake build settings for debugging
6060
run: powershell ${{ github.workspace }}/SourceCache/firebase-cpp-sdk/build_scripts/windows/fix_cmake_debugflags.ps1 ${{ github.workspace }}/SourceCache/firebase-cpp-sdk/CMakeLists.txt
6161

62+
# For curl we set '-D HAVE_IOCTLSOCKET_FIONBIO=1'. This should automatically be set to 1 by
63+
# https://github.com/curl/curl/blob/60580f9f214869b501ba0caaa5a6bf335e6aee1d/CMake/Platforms/WindowsCache.cmake
64+
# but this is not what we observe in CI.
6265
- name: Configure firebase
6366
run:
6467
cmake -B ${{ github.workspace }}/BinaryCache/firebase `
@@ -79,6 +82,7 @@ jobs:
7982
-D CMAKE_C_FLAGS="/D_HAS_EXCEPTIONS=0 /EHsc-"`
8083
-D CMAKE_CXX_FLAGS="/D_HAS_EXCEPTIONS=0 /EHsc-" `
8184
-D CMAKE_MSVC_DEBUG_INFORMATION_FORMAT=Embedded `
85+
-D HAVE_IOCTLSOCKET_FIONBIO=1 `
8286
-D FIREBASE_PYTHON_HOST_EXECUTABLE:FILEPATH=${{ steps.python.outputs.python-path }} `
8387
-D FLATBUFFERS_FLATC_EXECUTABLE=${{ github.workspace }}/BinaryCache/flatbuffers/Release/flatc.exe
8488

0 commit comments

Comments
 (0)