refactor replies to always defer

Author: BenjammingKirby

src/commands/docs/djs.ts

@@ -43,7 +43,7 @@ const command: Command = {
         const doc = await Doc.fetch(source, { force: true }).catch(console.error);
 
         if (!doc) {
-            await interaction.reply({ content: "Couldn't fetch docs", ephemeral: true }).catch(console.error);
+            await interaction.editReply({ content: "Couldn't fetch docs" }).catch(console.error);
             return;
         }
         // const resultEmbed = doc.resolveEmbed(query, { excludePrivateElements: !searchPrivate });
@@ -57,7 +57,7 @@ const command: Command = {
             // Satisfies the method's MessageEmbedOption type
             const embedObj = { ...notFoundEmbed, timestamp: timeStampDate };
 
-            await interaction.reply({ embeds: [embedObj], ephemeral: true }).catch(console.error);
+            await interaction.editReply({ embeds: [embedObj] }).catch(console.error);
             return;
         } else if (Array.isArray(result)) {
             // If there are multiple results, send a select menu from which the user can choose which one to send
@@ -69,9 +69,8 @@ const command: Command = {
                     .setPlaceholder("Select documentation to send"),
             );
             await interaction
-                .reply({
+                .editReply({
                     content: "Didn't find an exact match, please select one from below",
-                    ephemeral: true,
                     components: [selectMenuRow],
                 })
                 .catch(console.error);
@@ -87,7 +86,10 @@ const command: Command = {
             // The final field should be the View Source button
             embedObj.fields = [embedObj.fields?.at(-1)];
         }
-        await interaction.reply({ embeds: [embedObj], components: [deleteButtonRow] }).catch(console.error);
+        await interaction.editReply({
+            content: "Sent documentations for " + (query.length >= 100 ? query.slice(0, 100) + "..." : query),
+        });
+        await interaction.followUp({ embeds: [embedObj], components: [deleteButtonRow] }).catch(console.error);
         return;
     },
 };

src/commands/docs/mdn.ts

@@ -46,17 +46,19 @@ const command: Command = {
 
         if (!search.length) {
             embed.setColor(0xff0000).setDescription("No results found...");
-            await interaction.reply({ embeds: [embed], ephemeral: true }).catch(console.error);
+            await interaction.editReply({ embeds: [embed] }).catch(console.error);
             return;
         } else if (search.length === 1) {
             const resultEmbed = await getSingleMDNSearchResults(search[0]);
             if (!resultEmbed) {
-                await interaction.reply({ content: "Couldn't find any results", ephemeral: true }).catch(console.error);
+                await interaction.editReply({ content: "Couldn't find any results" }).catch(console.error);
                 return;
             }
-
             await interaction
-                .reply({
+                .editReply("Sent documentation for " + (query.length >= 100 ? query.slice(0, 100) + "..." : query))
+                .catch(console.error);
+            await interaction
+                .followUp({
                     embeds: [resultEmbed],
                     components: [deleteButtonRow],
                 })
@@ -77,9 +79,8 @@ const command: Command = {
                     .setPlaceholder("Select documentation to send"),
             );
             await interaction
-                .reply({
+                .editReply({
                     content: "Didn't find an exact match, please select one from below",
-                    ephemeral: true,
                     components: [selectMenuRow],
                 })
                 .catch(console.error);

src/handlers/InteractionCreateHandler.ts

@@ -58,8 +58,10 @@ export function loadCommands(context: MyContext) {
     });
 }
 async function commandInteractionHandler(context: MyContext, interaction: CommandInteraction) {
+    await interaction.deferReply({ ephemeral: true }).catch(console.error);
+
     const command = context.commands.get(interaction.commandName);
-    if (!command) return interaction.reply({ content: "Command not found", ephemeral: true });
+    if (!command) return interaction.editReply({ content: "Command not found" }).catch(console.error);
 
     if (commandPermissionCheck(interaction, command)) return;
     if (commandCooldownCheck(interaction, command, context)) return;
@@ -68,15 +70,13 @@ async function commandInteractionHandler(context: MyContext, interaction: Comman
     } catch (e) {
         console.error(e);
         const errorMessage = "An error has occurred";
-        interaction
-            .reply({
-                content: errorMessage,
-                ephemeral: true,
-            })
-            .catch(console.error);
+        await interaction[interaction.replied ? "editReply" : "reply"]?.({
+            content: errorMessage,
+        }).catch(console.error);
     }
 }
 async function selectMenuInteractionHandler(context: MyContext, interaction: SelectMenuInteraction) {
+    await interaction.deferUpdate().catch(console.error);
     const CommandName = interaction.customId.split("/")[0];
     switch (CommandName) {
         case "mdnselect": {
@@ -87,7 +87,7 @@ async function selectMenuInteractionHandler(context: MyContext, interaction: Sel
 
             // Remove the menu and update the ephemeral message
             await interaction
-                .update({ content: "Sent documentations for " + selectedValue, components: [] })
+                .editReply({ content: "Sent documentations for " + selectedValue, components: [] })
                 .catch(console.error);
             // Send documentation
             await interaction.followUp({ embeds: [resultEmbed], components: [deleteButtonRow] }).catch(console.error);
@@ -105,14 +105,14 @@ async function selectMenuInteractionHandler(context: MyContext, interaction: Sel
 
             // Remove the menu and update the ephemeral message
             await interaction
-                .update({ content: "Sent documentations for " + selectedValue, components: [] })
+                .editReply({ content: "Sent documentations for " + selectedValue, components: [] })
                 .catch(console.error);
             // Send documentation
             await interaction.followUp({ embeds: [resultEmbed], components: [deleteButtonRow] }).catch(console.error);
             break;
         }
         default: {
-            interaction.reply({ content: "Unknown menu", ephemeral: true }).catch(console.error);
+            interaction.editReply({ content: "Unknown menu" }).catch(console.error);
         }
     }
 }