refactor(no-container): add scenario

| destructure method from container

Author: thebinaryfelix

lib/rules/no-container.ts

@@ -43,9 +43,10 @@ export default ESLintUtils.RuleCreator(getDocsUrl)({
 
   create(context, [options]) {
     const { renderFunctions } = options;
-    let containerName = '';
-    let renderWrapperName = '';
     let hasPropertyContainer = false;
+    let containerName: string = null;
+    let renderWrapperName: string = null;
+    const destructuredContainerPropNames: string[] = [];
 
     return {
       VariableDeclarator(node) {
@@ -59,7 +60,17 @@ export default ESLintUtils.RuleCreator(getDocsUrl)({
             );
             const nodeValue =
               containerIndex !== -1 && node.id.properties[containerIndex].value;
-            containerName = isIdentifier(nodeValue) && nodeValue.name;
+            if (isIdentifier(nodeValue)) {
+              containerName = nodeValue.name;
+            } else {
+              isObjectPattern(nodeValue) &&
+                nodeValue.properties.forEach(
+                  property =>
+                    isProperty(property) &&
+                    isIdentifier(property.key) &&
+                    destructuredContainerPropNames.push(property.key.name)
+                );
+            }
           } else {
             renderWrapperName = isIdentifier(node.id) && node.id.name;
           }
@@ -83,7 +94,7 @@ export default ESLintUtils.RuleCreator(getDocsUrl)({
 
               if (isContainerName || hasPropertyContainer) {
                 context.report({
-                  node,
+                  node: innerNode,
                   messageId: 'noContainer',
                 });
               }
@@ -95,6 +106,12 @@ export default ESLintUtils.RuleCreator(getDocsUrl)({
         }
         if (isMemberExpression(node.callee)) {
           showErrorForChainedContainerMethod(node.callee);
+        } else if (isIdentifier(node.callee)) {
+          destructuredContainerPropNames.includes(node.callee.name) &&
+            context.report({
+              node,
+              messageId: 'noContainer',
+            });
         }
       },
     };

tests/lib/rules/no-container.test.ts

@@ -37,7 +37,7 @@ ruleTester.run(RULE_NAME, rule, {
             <button>Print Username</button>
           \`;
           const button = container.querySelector('button');
-      
+
           button.addEventListener('click', () => console.log('clicked'));
           return container;
       }
@@ -46,6 +46,12 @@ ruleTester.run(RULE_NAME, rule, {
       screen.getByText(exampleDOM, 'Print Username').click();
       `,
     },
+    {
+      code: `
+        const { container: { firstChild } } = render(<Example />);
+        expect(firstChild).toBeDefined();
+      `,
+    },
   ],
   invalid: [
     {
@@ -83,8 +89,19 @@ ruleTester.run(RULE_NAME, rule, {
     },
     {
       code: `
-        const view = render(<Example />)
-        const button = view.container.querySelector('.btn-primary')
+        const view = render(<Example />);
+        const button = view.container.querySelector('.btn-primary');
+      `,
+      errors: [
+        {
+          messageId: 'noContainer',
+        },
+      ],
+    },
+    {
+      code: `
+        const { container: { querySelector } } = render(<Example />);
+        querySelector('foo');
       `,
       errors: [
         {