refactor(no-debug): extract auxiliary functions

to node-utils, to be used by no-container

Author: Mateus Felix

lib/node-utils.ts

@@ -105,4 +105,37 @@ export function hasThenProperty(node: TSESTree.Node) {
 
 export function isArrowFunctionExpression(node: TSESTree.Node): node is TSESTree.ArrowFunctionExpression {
   return node && node.type === 'ArrowFunctionExpression'
+}
+
+function isRenderFunction(
+  callNode: TSESTree.CallExpression,
+  renderFunctions: string[]
+) {
+  return ['render', ...renderFunctions].some(
+    name => isIdentifier(callNode.callee) && name === callNode.callee.name
+  );
+}
+
+export function isRenderVariableDeclarator(
+  node: TSESTree.VariableDeclarator,
+  renderFunctions: string[] = []
+) {
+  if (node.init) {
+    if (isAwaitExpression(node.init)) {
+      return (
+        node.init.argument &&
+        isRenderFunction(
+          node.init.argument as TSESTree.CallExpression,
+          renderFunctions
+        )
+      );
+    } else {
+      return (
+        isCallExpression(node.init) &&
+        isRenderFunction(node.init, renderFunctions)
+      );
+    }
+  }
+
+  return false;
 }

lib/rules/no-container.ts

@@ -6,22 +6,11 @@ import {
   isMemberExpression,
   isObjectPattern,
   isProperty,
+  isRenderVariableDeclarator,
 } from '../node-utils';
 
 export const RULE_NAME = 'no-container';
 
-function isRender(callNode: TSESTree.CallExpression) {
-  return isIdentifier(callNode.callee) && callNode.callee.name === 'render';
-}
-
-function isRenderVariableDeclarator(node: TSESTree.VariableDeclarator) {
-  if (node.init) {
-    if (isCallExpression(node.init)) {
-      return isRender(node.init);
-    }
-  }
-}
-
 export default ESLintUtils.RuleCreator(getDocsUrl)({
   name: RULE_NAME,
   meta: {
@@ -32,7 +21,8 @@ export default ESLintUtils.RuleCreator(getDocsUrl)({
       recommended: 'error',
     },
     messages: {
-      noContainer: 'Unexpected use of container methods. Prefer the use of "screen.someMethod()".',
+      noContainer:
+        'Unexpected use of container methods. Prefer the use of "screen.someMethod()".',
     },
     fixable: null,
     schema: [],

lib/rules/no-debug.ts

@@ -6,46 +6,13 @@ import {
   isIdentifier,
   isCallExpression,
   isLiteral,
-  isAwaitExpression,
   isMemberExpression,
   isImportSpecifier,
+  isRenderVariableDeclarator,
 } from '../node-utils';
 
 export const RULE_NAME = 'no-debug';
 
-function isRenderFunction(
-  callNode: TSESTree.CallExpression,
-  renderFunctions: string[]
-) {
-  return ['render', ...renderFunctions].some(
-    name => isIdentifier(callNode.callee) && name === callNode.callee.name
-  );
-}
-
-function isRenderVariableDeclarator(
-  node: TSESTree.VariableDeclarator,
-  renderFunctions: string[]
-) {
-  if (node.init) {
-    if (isAwaitExpression(node.init)) {
-      return (
-        node.init.argument &&
-        isRenderFunction(
-          node.init.argument as TSESTree.CallExpression,
-          renderFunctions
-        )
-      );
-    } else {
-      return (
-        isCallExpression(node.init) &&
-        isRenderFunction(node.init, renderFunctions)
-      );
-    }
-  }
-
-  return false;
-}
-
 function hasTestingLibraryImportModule(
   importDeclarationNode: TSESTree.ImportDeclaration
 ) {