test: add ESLint 8.x tests (#200)

Author: MichaelDeBoey

.github/workflows/validate.yml

@@ -16,7 +16,7 @@ jobs:
     if: ${{ !contains(github.head_ref, 'all-contributors') }}
     strategy:
       matrix:
-        eslint: [6.8.0, 6, 7.0.0, 7]
+        eslint: [6.8.0, 6, 7.0.0, 7, 8.0.0, 8]
         node: [12.22.0, 12, 14.17.0, 14, 16.0.0, 16]
     runs-on: ubuntu-latest
     steps:
@@ -40,11 +40,11 @@ jobs:
         run: npm install --no-save --force eslint@${{ matrix.eslint }}
 
       - name: ▶️ Run validate script (without linting)
-        if: ${{ matrix.eslint != 7 }}
+        if: ${{ matrix.eslint != 8 }}
         run: npm run validate -- build,test:coverage
 
       - name: ▶️ Run validate script (with linting)
-        if: ${{ matrix.eslint == 7 }}
+        if: ${{ matrix.eslint == 8 }}
         run: npm run validate
 
       - name: ⬆️ Upload coverage report

package.json

@@ -45,23 +45,22 @@
     "requireindex": "^1.2.0"
   },
   "devDependencies": {
-    "@typescript-eslint/parser": "^4.33.0",
-    "eslint": "^7.31.0",
-    "eslint-remote-tester": "^2.0.1",
+    "@typescript-eslint/parser": "^5.9.1",
+    "eslint": "^8.7.0",
+    "eslint-remote-tester": "^2.1.1",
     "eslint-remote-tester-repositories": "^0.0.4",
-    "kcd-scripts": "^11.2.2",
+    "kcd-scripts": "^12.0.0",
     "typescript": "^4.5.3"
   },
   "peerDependencies": {
-    "eslint": ">=6.8"
+    "eslint": "^6.8.0 || ^7.0.0 || ^8.0.0"
   },
   "eslintConfig": {
     "extends": "./node_modules/kcd-scripts/eslint.js",
     "rules": {
-      "babel/quotes": "off",
+      "consistent-return": "off",
       "max-lines-per-function": "off",
-      "testing-library/no-dom-import": "off",
-      "consistent-return": "off"
+      "testing-library/no-dom-import": "off"
     }
   },
   "eslintIgnore": [

src/rules/prefer-to-have-class.js

@@ -116,14 +116,18 @@ export const create = (context) => ({
       classValue.type === "CallExpression" &&
       classValue.callee.type === "MemberExpression" &&
       classValue.callee.object.name === "expect"
-    )
+    ) {
       return;
+    }
+
     context.report({
       node: matcher,
       messageId,
       fix(fixer) {
-        if (checkedProp.name === "classList" && matcher.name !== "toContain")
+        if (checkedProp.name === "classList" && matcher.name !== "toContain") {
           return;
+        }
+
         return [
           fixer.removeRange([classNameProp.range[1], checkedProp.range[1]]),
           fixer.replaceText(matcher, "toHaveClass"),
@@ -182,8 +186,9 @@ export const create = (context) => ({
       node: matcher,
       messageId,
       fix(fixer) {
-        if (className.name === "classList" && matcher.name !== "toContain")
+        if (className.name === "classList" && matcher.name !== "toContain") {
           return;
+        }
 
         return [
           fixer.removeRange([classNameProp.range[1], className.range[1]]),
@@ -215,8 +220,9 @@ export const create = (context) => ({
     if (
       (matcher.name === "toHaveAttribute" && classNameValue !== "class") ||
       (matcher.name === "toHaveProperty" && classNameValue !== "className")
-    )
+    ) {
       return;
+    }
 
     const { isDTLQuery } = getQueryNodeFrom(
       context,
@@ -255,8 +261,10 @@ export const create = (context) => ({
     if (
       (matcher.name === "toHaveAttribute" && classNameValue !== "class") ||
       (matcher.name === "toHaveProperty" && classNameValue !== "className")
-    )
+    ) {
       return;
+    }
+
     const { isDTLQuery } = getQueryNodeFrom(
       context,
       node.callee.object.object.arguments[0]
@@ -295,8 +303,9 @@ export const create = (context) => ({
     if (
       (matcher.name === "toHaveAttribute" && classNameValue !== "class") ||
       (matcher.name === "toHaveProperty" && classNameValue !== "className")
-    )
+    ) {
       return;
+    }
 
     const { isDTLQuery } = getQueryNodeFrom(
       context,