fix: Ensure both ECS service definitions use the same settings/configurations (#277)

* fix: ensure ECS service tags are propagated

This fixes the issue specifically with the `ignore_task_definition` service type.

* fix: Sync both serice definitions

---------

Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>

Author: will-abb

.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 repos:
   - repo: https://github.com/antonbabenko/pre-commit-terraform
-    rev: v1.96.1
+    rev: v1.99.0
     hooks:
       - id: terraform_fmt
       - id: terraform_wrapper_module_for_each

modules/service/main.tf

@@ -285,7 +285,7 @@ resource "aws_ecs_service" "ignore_task_definition" {
 
   dynamic "network_configuration" {
     # Set by task set if deployment controller is external
-    for_each = var.network_mode == "awsvpc" ? [{ for k, v in local.network_configuration : k => v if !local.is_external_deployment }] : []
+    for_each = var.network_mode == "awsvpc" && !local.is_external_deployment ? [local.network_configuration] : []
 
     content {
       assign_public_ip = network_configuration.value.assign_public_ip
@@ -381,7 +381,7 @@ resource "aws_ecs_service" "ignore_task_definition" {
   wait_for_steady_state = var.wait_for_steady_state
 
   propagate_tags = var.propagate_tags
-  tags           = var.tags
+  tags           = merge(var.tags, var.service_tags)
 
   timeouts {
     create = try(var.timeouts.create, null)