Skip to content

Commit ea4c829

Browse files
author
yuanhaojin
committed
meaningless err handling
1 parent 39d9e06 commit ea4c829

File tree

7 files changed

+7
-26
lines changed

7 files changed

+7
-26
lines changed

tencentcloud/common.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ func CheckNil(object interface{}, fields map[string]string) (nilFields []string)
191191
return
192192
}
193193

194-
// BuildTagResourceName builds the Tencent Clould specific name of a resource description.
194+
// BuildTagResourceName builds the Tencent Cloud specific name of a resource description.
195195
// The format is `qcs:project_id:service_type:region:account:resource`.
196196
// For more information, go to https://cloud.tencent.com/document/product/598/10606.
197197
func BuildTagResourceName(serviceType, resourceType, region, id string) string {

tencentcloud/resource_tc_as_scaling_group.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -438,10 +438,7 @@ func resourceTencentCloudAsScalingGroupRead(d *schema.ResourceData, meta interfa
438438
return err
439439
}
440440

441-
if err := d.Set("tags", tags); err != nil {
442-
log.Printf("[CRITAL]%s provider set tags fail, reason:%s\n ", logId, err.Error())
443-
return err
444-
}
441+
_ = d.Set("tags", tags)
445442

446443
return nil
447444
}

tencentcloud/resource_tc_cbs_storage.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -291,10 +291,7 @@ func resourceTencentCloudCbsStorageRead(d *schema.ResourceData, meta interface{}
291291
return err
292292
}
293293

294-
if err := d.Set("tags", tags); err != nil {
295-
log.Printf("[CRITAL]%s provider set tags fail, reason:%s\n ", logId, err.Error())
296-
return err
297-
}
294+
_ = d.Set("tags", tags)
298295

299296
return nil
300297
}

tencentcloud/resource_tc_ccn.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ package tencentcloud
2424
import (
2525
"context"
2626
"fmt"
27-
"log"
2827
"strings"
2928

3029
"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
@@ -160,10 +159,7 @@ func resourceTencentCloudCcnRead(d *schema.ResourceData, meta interface{}) error
160159
return err
161160
}
162161

163-
if err := d.Set("tags", tags); err != nil {
164-
log.Printf("[CRITAL]%s provider set tags fail, reason:%s\n ", logId, err.Error())
165-
return err
166-
}
162+
_ = d.Set("tags", tags)
167163
return nil
168164
}
169165

tencentcloud/resource_tc_cfs_file_system.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -240,10 +240,7 @@ func resourceTencentCloudCfsFileSystemRead(d *schema.ResourceData, meta interfac
240240
return err
241241
}
242242

243-
if err := d.Set("tags", tags); err != nil {
244-
log.Printf("[CRITAL]%s provider set tags fail, reason:%s\n ", logId, err.Error())
245-
return err
246-
}
243+
_ = d.Set("tags", tags)
247244

248245
if mountTarget != nil {
249246
_ = d.Set("vpc_id", mountTarget.VpcId)

tencentcloud/resource_tc_clb_instance.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -343,10 +343,7 @@ func resourceTencentCloudClbInstanceRead(d *schema.ResourceData, meta interface{
343343
return err
344344
}
345345

346-
if err := d.Set("tags", tags); err != nil {
347-
log.Printf("[CRITAL]%s provider set tags fail, reason:%s\n ", logId, err.Error())
348-
return err
349-
}
346+
_ = d.Set("tags", tags)
350347
return nil
351348
}
352349

tencentcloud/resource_tc_redis_instance.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -481,10 +481,7 @@ func resourceTencentCloudRedisInstanceRead(d *schema.ResourceData, meta interfac
481481
return err
482482
}
483483

484-
if err := d.Set("tags", tags); err != nil {
485-
log.Printf("[CRITAL]%s provider set tags fail, reason:%s\n ", logId, err.Error())
486-
return err
487-
}
484+
_ = d.Set("tags", tags)
488485

489486
_ = d.Set("charge_type", REDIS_CHARGE_TYPE_NAME[*info.BillingMode])
490487
return nil

0 commit comments

Comments
 (0)