Skip to content

Commit 147c498

Browse files
authored
Merge pull request #2949 from tarlepp/chore(ci)/disable-phpinsights
Chore(ci) - Disabled `PHP Insights` tool `ForbiddenSecurityIssues` check
2 parents 398763a + e290018 commit 147c498

File tree

2 files changed

+2
-14
lines changed

2 files changed

+2
-14
lines changed

phpinsights.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@
5353
// ExampleInsight::class,
5454
NunoMaduro\PhpInsights\Domain\Insights\Composer\ComposerMustBeValid::class,
5555
NunoMaduro\PhpInsights\Domain\Insights\ForbiddenNormalClasses::class,
56+
// Disabled for now because of the - https://github.com/nunomaduro/phpinsights/issues/704
57+
NunoMaduro\PhpInsights\Domain\Insights\ForbiddenSecurityIssues::class,
5658
NunoMaduro\PhpInsights\Domain\Insights\ForbiddenTraits::class,
5759
NunoMaduro\PhpInsights\Domain\Sniffs\ForbiddenSetterSniff::class,
5860
ObjectCalisthenics\Sniffs\Classes\ForbiddenPublicPropertySniff::class,

tests/Integration/TestCase/RestIntegrationControllerTestCase.php

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
1515
use UnexpectedValueException;
1616
use function assert;
17-
use function gc_collect_cycles;
18-
use function gc_enable;
1917
use function mb_substr;
2018
use function sprintf;
2119

@@ -40,8 +38,6 @@ abstract class RestIntegrationControllerTestCase extends KernelTestCase
4038
#[Override]
4139
protected function setUp(): void
4240
{
43-
gc_enable();
44-
4541
parent::setUp();
4642

4743
$controller = static::getContainer()->get($this->controllerClass);
@@ -51,16 +47,6 @@ protected function setUp(): void
5147
$this->controller = $controller;
5248
}
5349

54-
#[Override]
55-
protected function tearDown(): void
56-
{
57-
parent::tearDown();
58-
59-
unset($this->controller);
60-
61-
gc_collect_cycles();
62-
}
63-
6450
public function testThatGivenControllerIsCorrect(): void
6551
{
6652
$expected = mb_substr((new ReflectionClass($this))->getShortName(), 0, -4);

0 commit comments

Comments
 (0)