Replace interrupt masking with spinlock in timer for SMP support

The timer subsystem originally used NOSCHED_ENTER() and NOSCHED_LEAVE()
to disable interrupts when accessing shared timer state, which sufficed
on single-core systems.

To support SMP, we now replace these macros with a spinlock based on
RV32A atomic instructions. This ensures safe concurrent access to
global timer state such as timer_initialized, the timer list, and ID
management.

This change prepares the timer subsystem for correct operation when
multiple harts simultaneously create, start, or cancel timers.

Author: visitorckw

kernel/timer.c

@@ -8,6 +8,7 @@
  */
 
 #include <hal.h>
+#include <spinlock.h>
 #include <lib/list.h>
 #include <lib/malloc.h>
 #include <sys/task.h>
@@ -32,6 +33,9 @@ static struct {
 } timer_cache[4];
 static uint8_t timer_cache_index = 0;
 
+static spinlock_t timer_lock = SPINLOCK_INITIALIZER;
+static uint32_t timer_flags = 0;
+
 /* Get a node from the pool, fall back to malloc if pool is empty */
 static list_node_t *get_timer_node(void)
 {
@@ -83,9 +87,9 @@ static int32_t timer_subsystem_init(void)
     if (unlikely(timer_initialized))
         return ERR_OK;
 
-    NOSCHED_ENTER();
+    spin_lock_irqsave(&timer_lock, &timer_flags);
     if (timer_initialized) {
-        NOSCHED_LEAVE();
+        spin_unlock_irqrestore(&timer_lock, timer_flags);
         return ERR_OK;
     }
 
@@ -101,7 +105,7 @@ static int32_t timer_subsystem_init(void)
             list_destroy(kcb->timer_list);
             kcb->timer_list = NULL;
         }
-        NOSCHED_LEAVE();
+        spin_unlock_irqrestore(&timer_lock, timer_flags);
         return ERR_FAIL;
     }
 
@@ -112,7 +116,7 @@ static int32_t timer_subsystem_init(void)
     }
 
     timer_initialized = true;
-    NOSCHED_LEAVE();
+    spin_unlock_irqrestore(&timer_lock, timer_flags);
     return ERR_OK;
 }
 
@@ -294,7 +298,7 @@ int32_t mo_timer_create(void *(*callback)(void *arg),
     if (unlikely(!t))
         return ERR_FAIL;
 
-    NOSCHED_ENTER();
+    spin_lock_irqsave(&timer_lock, &timer_flags);
 
     /* Initialize timer */
     t->id = next_id++;
@@ -307,15 +311,15 @@ int32_t mo_timer_create(void *(*callback)(void *arg),
 
     /* Insert into sorted all_timers_list */
     if (unlikely(timer_insert_sorted_by_id(t) != ERR_OK)) {
-        NOSCHED_LEAVE();
+        spin_unlock_irqrestore(&timer_lock, timer_flags);
         free(t);
         return ERR_FAIL;
     }
 
     /* Add to cache */
     cache_timer(t->id, t);
 
-    NOSCHED_LEAVE();
+    spin_unlock_irqrestore(&timer_lock, timer_flags);
     return t->id;
 }
 
@@ -324,11 +328,11 @@ int32_t mo_timer_destroy(uint16_t id)
     if (unlikely(!timer_initialized))
         return ERR_FAIL;
 
-    NOSCHED_ENTER();
+    spin_lock_irqsave(&timer_lock, &timer_flags);
 
     list_node_t *node = timer_find_node_by_id(id);
     if (unlikely(!node)) {
-        NOSCHED_LEAVE();
+        spin_unlock_irqrestore(&timer_lock, timer_flags);
         return ERR_FAIL;
     }
 
@@ -351,7 +355,7 @@ int32_t mo_timer_destroy(uint16_t id)
     free(t);
     return_timer_node(node);
 
-    NOSCHED_LEAVE();
+    spin_unlock_irqrestore(&timer_lock, timer_flags);
     return ERR_OK;
 }
 
@@ -362,11 +366,11 @@ int32_t mo_timer_start(uint16_t id, uint8_t mode)
     if (unlikely(!timer_initialized))
         return ERR_FAIL;
 
-    NOSCHED_ENTER();
+    spin_lock_irqsave(&timer_lock, &timer_flags);
 
     timer_t *t = timer_find_by_id_fast(id);
     if (unlikely(!t)) {
-        NOSCHED_LEAVE();
+        spin_unlock_irqrestore(&timer_lock, timer_flags);
         return ERR_FAIL;
     }
 
@@ -380,11 +384,11 @@ int32_t mo_timer_start(uint16_t id, uint8_t mode)
 
     if (unlikely(timer_sorted_insert(t) != ERR_OK)) {
         t->mode = TIMER_DISABLED;
-        NOSCHED_LEAVE();
+        spin_unlock_irqrestore(&timer_lock, timer_flags);
         return ERR_FAIL;
     }
 
-    NOSCHED_LEAVE();
+    spin_unlock_irqrestore(&timer_lock, timer_flags);
     return ERR_OK;
 }
 
@@ -393,17 +397,17 @@ int32_t mo_timer_cancel(uint16_t id)
     if (unlikely(!timer_initialized))
         return ERR_FAIL;
 
-    NOSCHED_ENTER();
+    spin_lock_irqsave(&timer_lock, &timer_flags);
 
     timer_t *t = timer_find_by_id_fast(id);
     if (unlikely(!t || t->mode == TIMER_DISABLED)) {
-        NOSCHED_LEAVE();
+        spin_unlock_irqrestore(&timer_lock, timer_flags);
         return ERR_FAIL;
     }
 
     timer_remove_item_by_data(kcb->timer_list, t);
     t->mode = TIMER_DISABLED;
 
-    NOSCHED_LEAVE();
+    spin_unlock_irqrestore(&timer_lock, timer_flags);
     return ERR_OK;
 }