Add strict to tsconfig.json

Author: wooorm

lib/index.js

@@ -32,8 +32,11 @@ import {toH} from 'hast-to-hyperscript'
 import {webNamespaces} from 'web-namespaces'
 import {zwitch} from 'zwitch'
 
+const ns = /** @type {Record<string, string>} */ (webNamespaces)
+
 const own = {}.hasOwnProperty
 
+// @ts-expect-error: hush.
 const one = zwitch('type', {handlers: {root, element, text, comment, doctype}})
 
 /**
@@ -44,7 +47,7 @@ const one = zwitch('type', {handlers: {root, element, text, comment, doctype}})
  * @returns {P5Node}
  */
 export function toParse5(tree, space) {
-  // @ts-ignore Types are wrong.
+  // @ts-expect-error Types are wrong.
   return one(tree, space === 'svg' ? svg : html)
 }
 
@@ -60,7 +63,7 @@ function root(node, schema) {
     mode: (node.data || {}).quirksMode ? 'quirks' : 'no-quirks',
     childNodes: []
   }
-  // @ts-ignore Assume correct children.
+  // @ts-expect-error Assume correct children.
   p5.childNodes = all(node.children, p5, schema)
   return patch(node, p5)
 }
@@ -73,7 +76,7 @@ function root(node, schema) {
 function fragment(node, schema) {
   /** @type {P5Fragment} */
   const p5 = {nodeName: '#document-fragment', childNodes: []}
-  // @ts-ignore Assume correct children.
+  // @ts-expect-error Assume correct children.
   p5.childNodes = all(node.children, p5, schema)
   return patch(node, p5)
 }
@@ -99,11 +102,15 @@ function doctype(node) {
  * @returns {P5Text}
  */
 function text(node) {
-  return patch(node, {
-    nodeName: '#text',
-    value: node.value,
-    parentNode: undefined
-  })
+  return patch(
+    node,
+    // @ts-expect-error: no `parentNode`
+    /** @type {P5Text} */ ({
+      nodeName: '#text',
+      value: node.value,
+      parentNode: undefined
+    })
+  )
 }
 
 /**
@@ -112,11 +119,15 @@ function text(node) {
  * @returns {P5Comment}
  */
 function comment(node) {
-  return patch(node, {
-    nodeName: '#comment',
-    data: node.value,
-    parentNode: undefined
-  })
+  return patch(
+    node,
+    // @ts-expect-error: no `parentNode`
+    /** @type {P5Comment} */ ({
+      nodeName: '#comment',
+      data: node.value,
+      parentNode: undefined
+    })
+  )
 }
 
 /**
@@ -126,7 +137,7 @@ function comment(node) {
  */
 function element(node, schema) {
   /** @type {Space} */
-  // @ts-ignore Assume space.
+  // @ts-expect-error Assume space.
   const space = schema.space
   return toH(h, Object.assign({}, node, {children: []}), {space})
 
@@ -167,7 +178,7 @@ function element(node, schema) {
           value.prefix = key.slice(0, index)
         }
 
-        value.namespace = webNamespaces[info.space]
+        value.namespace = ns[info.space]
       }
 
       values.push(value)
@@ -176,19 +187,24 @@ function element(node, schema) {
     if (schema.space === 'html' && node.tagName === 'svg') schema = svg
 
     /** @type {P5Element} */
-    const p5 = patch(node, {
-      nodeName: name,
-      tagName: name,
-      attrs: values,
-      namespaceURI: webNamespaces[schema.space],
-      childNodes: [],
-      parentNode: undefined
-    })
-
-    // @ts-ignore Assume correct children.
+    const p5 = patch(
+      node,
+      // @ts-expect-error: no `parentNode`
+      /** @type {P5Element} */ ({
+        nodeName: name,
+        tagName: name,
+        attrs: values,
+        // @ts-expect-error: html and svg both have a space.
+        namespaceURI: ns[schema.space],
+        childNodes: [],
+        parentNode: undefined
+      })
+    )
+
+    // @ts-expect-error Assume correct children.
     p5.childNodes = all(node.children, p5, schema)
 
-    // @ts-ignore Types are wrong.
+    // @ts-expect-error Types are wrong.
     if (name === 'template') p5.content = fragment(node.content, schema)
 
     return p5
@@ -209,10 +225,10 @@ function all(children, p5, schema) {
   if (children) {
     while (++index < children.length) {
       /** @type {P5Child} */
-      // @ts-ignore Assume child.
+      // @ts-expect-error Assume child.
       const child = one(children[index], schema)
 
-      // @ts-ignore types are wrong.
+      // @ts-expect-error types are wrong.
       child.parentNode = p5
 
       result.push(child)
@@ -234,7 +250,7 @@ function patch(node, p5) {
   const position = node.position
 
   if (position && position.start && position.end) {
-    // @ts-ignore Types are wrong.
+    // @ts-expect-error Types are wrong.
     p5.sourceCodeLocation = {
       startLine: position.start.line,
       startCol: position.start.column,

test/comment.js

@@ -6,7 +6,7 @@ test('comment', (t) => {
   const actual = toParse5({type: 'comment', value: 'Alpha'})
   const expected = parse5.parseFragment('<!--Alpha-->').childNodes[0]
 
-  expected.parentNode = undefined
+  Object.assign(expected, {parentNode: undefined})
 
   t.deepEqual(actual, expected, 'should transform comments')
 

test/doctype.js

@@ -11,7 +11,7 @@ test('doctype', (t) => {
     })
     const expected = parse5.parse('<!DOCTYPE html>').childNodes[0]
 
-    expected.parentNode = undefined
+    Object.assign(expected, {parentNode: undefined})
 
     st.deepEqual(actual, expected)
 
@@ -22,7 +22,7 @@ test('doctype', (t) => {
     const actual = toParse5({type: 'doctype', name: 'html'})
     const expected = parse5.parse('<!doctypehtml>').childNodes[0]
 
-    expected.parentNode = undefined
+    Object.assign(expected, {parentNode: undefined})
 
     st.deepEqual(actual, expected)
 

test/element.js

@@ -12,7 +12,7 @@ test('element', (t) => {
     })
     const expected = parse5.parseFragment('<h1>Alpha').childNodes[0]
 
-    delete expected.parentNode
+    Object.assign(expected, {parentNode: undefined})
 
     st.deepEqual(json(actual), json(expected))
 
@@ -87,31 +87,31 @@ test('element', (t) => {
       ].join('')
     ).childNodes[0]
 
-    delete expected.parentNode
+    Object.assign(expected, {parentNode: undefined})
 
     st.deepEqual(json(actual), json(expected))
 
     st.end()
   })
 
   t.test('should transform void elements', (st) => {
-    // @ts-ignore runtime.
+    // @ts-expect-error runtime.
     const actual = toParse5({
       type: 'element',
       tagName: 'img',
       properties: {src: '#', alt: ''}
     })
     const expected = parse5.parseFragment('<img src=# alt="">').childNodes[0]
 
-    delete expected.parentNode
+    Object.assign(expected, {parentNode: undefined})
 
     st.deepEqual(json(actual), json(expected))
 
     st.end()
   })
 
   t.test('should transform templates with elements', (st) => {
-    // @ts-ignore runtime.
+    // @ts-expect-error runtime.
     const actual = toParse5({
       type: 'element',
       tagName: 'template',
@@ -124,15 +124,15 @@ test('element', (t) => {
     const expected = parse5.parseFragment('<template id="a">Alpha</template>')
       .childNodes[0]
 
-    delete expected.parentNode
+    Object.assign(expected, {parentNode: undefined})
 
     st.deepEqual(json(actual), json(expected))
 
     st.end()
   })
 
   t.test('should transform templates with text', (st) => {
-    // @ts-ignore runtime.
+    // @ts-expect-error runtime.
     const actual = toParse5({
       type: 'element',
       tagName: 'template',
@@ -159,7 +159,7 @@ test('element', (t) => {
       '<template id="b"><b>bold</b> and <i>italic</i></template>'
     ).childNodes[0]
 
-    delete expected.parentNode
+    Object.assign(expected, {parentNode: undefined})
 
     st.deepEqual(json(actual), json(expected))
 

test/position.js

@@ -27,9 +27,9 @@ test('position', (t) => {
     sourceCodeLocationInfo: true
   }).childNodes[0]
 
-  delete expected.parentNode
+  Object.assign(expected, {parentNode: undefined})
 
-  // @ts-ignore Types are wrong.
+  // @ts-expect-error Types are wrong.
   // Not possible yet to map this one.
   delete expected.sourceCodeLocation.startTag
 

test/svg.js

@@ -39,7 +39,7 @@ test('svg', (t) => {
       ].join('')
     ).childNodes[0]
 
-    delete expected.parentNode
+    Object.assign(expected, {parentNode: undefined})
 
     st.deepEqual(json(actual), json(expected))
 
@@ -58,7 +58,7 @@ test('svg', (t) => {
 
     const expected = parse5.parseFragment(
       '<svg><circle cx="60"  cy="60" r="50" fill="red"/></svg>'
-      // @ts-ignore runtime.
+      // @ts-expect-error runtime.
     ).childNodes[0].childNodes[0]
 
     delete expected.parentNode

test/text.js

@@ -5,7 +5,7 @@ import {toParse5} from '../index.js'
 test('text', (t) => {
   const expected = parse5.parseFragment('Alpha').childNodes[0]
 
-  expected.parentNode = undefined
+  Object.assign(expected, {parentNode: undefined})
 
   t.deepEqual(
     toParse5({type: 'text', value: 'Alpha'}),

tsconfig.json

@@ -10,6 +10,7 @@
     "declaration": true,
     "emitDeclarationOnly": true,
     "allowSyntheticDefaultImports": true,
-    "skipLibCheck": true
+    "skipLibCheck": true,
+    "strict": true
   }
 }