Merge branch '5.4' into 6.0

* 5.4: (22 commits)
  Fix composer on appveyor
  fix bootstrap_3_layout ChoiceType's expanded label_html
  [PropertyAccess] Fix typo in PropertyAccessor::readProperty() DocBlock
  [PropertyInfo] PhpStanExtractor namespace missmatch issue
  [VarExporter] Fix exporting objects with readonly properties
  [ExpressionLanguage] Fix matches when the regexp is not valid
  [Messenger] Add mysql indexes back and work around deadlocks using soft-delete
  Add BC layer to handle old objects already present in cache
  [RateLimiter] Always store SlidingWindows with an expiration set
  [Validator] Fix File constraint invalid max size exception message
  [Console] Fix exit status on uncaught exception with negative code
  [Validator] fix #43345 @Assert\DivisibleBy
  [HttpClient] fix 303 after PUT and sending chunked requests
  [HttpClient] always send Content-Type when a body is passed
  [HttpClient] always send Content-Length when a body is passed
  [HttpClient] fix sending Content-Length/Type for POST
  Fix merge
  [HttpClient] fix sending PUT requests with curl
  Fix locales format in CrowdinProvider
  Fix intersect in TranslatorBag
  ...

Author: nicolas-grekas

Constraints/DivisibleByValidator.php

@@ -42,6 +42,12 @@ protected function compareValues(mixed $value1, mixed $value2): bool
         if (!$remainder = fmod($value1, $value2)) {
             return true;
         }
+        if (\is_float($value2) && \INF !== $value2) {
+            $quotient = $value1 / $value2;
+            $rounded = round($quotient);
+
+            return sprintf('%.12e', $quotient) === sprintf('%.12e', $rounded);
+        }
 
         return sprintf('%.12e', $value2) === sprintf('%.12e', $remainder);
     }

Constraints/File.php

@@ -152,7 +152,7 @@ private function normalizeBinaryFormat(int|string $maxSize)
             $this->maxSize = $matches[1] * $factors[$unit = strtolower($matches[2])];
             $this->binaryFormat = $this->binaryFormat ?? (2 === \strlen($unit));
         } else {
-            throw new ConstraintDefinitionException(sprintf('"%s" is not a valid maximum size.', $this->maxSize));
+            throw new ConstraintDefinitionException(sprintf('"%s" is not a valid maximum size.', $maxSize));
         }
     }
 }

Tests/Constraints/DivisibleByValidatorTest.php

@@ -46,6 +46,18 @@ public function provideValidComparisons(): array
             [0, 3.1415],
             [42, 42],
             [42, 21],
+            [10.12, 0.01],
+            [10.12, 0.001],
+            [1.133, 0.001],
+            [1.1331, 0.0001],
+            [1.13331, 0.00001],
+            [1.13331, 0.000001],
+            [1, 0.1],
+            [1, 0.01],
+            [1, 0.001],
+            [1, 0.0001],
+            [1, 0.00001],
+            [1, 0.000001],
             [3.25, 0.25],
             ['100', '10'],
             [4.1, 0.1],
@@ -74,6 +86,7 @@ public function provideInvalidComparisons(): array
             [10, '10', 0, '0', 'int'],
             [42, '42', \INF, 'INF', 'float'],
             [4.15, '4.15', 0.1, '0.1', 'float'],
+            [10.123, '10.123', 0.01, '0.01', 'float'],
             ['22', '"22"', '10', '"10"', 'string'],
         ];
     }

Tests/Constraints/FileValidatorTest.php

@@ -517,5 +517,14 @@ public function uploadedFileErrorProvider()
         return $tests;
     }
 
+    public function testNegativeMaxSize()
+    {
+        $this->expectException(ConstraintDefinitionException::class);
+        $this->expectExceptionMessage('"-1" is not a valid maximum size.');
+
+        $file = new File();
+        $file->maxSize = -1;
+    }
+
     abstract protected function getFile($filename);
 }