minor #5597 [CreateFramework] don't override existing variables (xabbuh)

wouterj · wouterj · commit c0676f32a15e · 2015-08-20T10:49:49.000+02:00
This PR was merged into the 2.3 branch. Discussion ---------- [CreateFramework] don't override existing variables | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | #5568 When extracting the request attributes, existing variables must not be overridden so that the `$request` variable is passed to the template as is. Commits ------- 4b23fdc don't override existing variables
diff --git a/create_framework/templating.rst b/create_framework/templating.rst
@@ -41,7 +41,7 @@ rendered::
 
     function render_template($request)
     {
-        extract($request->attributes->all());
+        extract($request->attributes->all(), EXTR_SKIP);
         ob_start();
         include sprintf(__DIR__.'/../src/pages/%s.php', $_route);
 
@@ -110,7 +110,7 @@ Here is the updated and improved version of our framework::
 
     function render_template($request)
     {
-        extract($request->attributes->all());
+        extract($request->attributes->all(), EXTR_SKIP);
         ob_start();
         include sprintf(__DIR__.'/../src/pages/%s.php', $_route);
 

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ rendered::`
`41`	`41`
`42`	`42`	`function render_template($request)`
`43`	`43`	`{`
`44`		`- extract($request->attributes->all());`
	`44`	`+ extract($request->attributes->all(), EXTR_SKIP);`
`45`	`45`	`ob_start();`
`46`	`46`	`include sprintf(__DIR__.'/../src/pages/%s.php', $_route);`
`47`	`47`
`@@ -110,7 +110,7 @@ Here is the updated and improved version of our framework::`
`110`	`110`
`111`	`111`	`function render_template($request)`
`112`	`112`	`{`
`113`		`- extract($request->attributes->all());`
	`113`	`+ extract($request->attributes->all(), EXTR_SKIP);`
`114`	`114`	`ob_start();`
`115`	`115`	`include sprintf(__DIR__.'/../src/pages/%s.php', $_route);`
`116`	`116`