Merge branch '4.4' into 5.2

* 4.4:
  [Validator] Use import instead of FQCN
  [Validator] Use null coalescing operator instead of ternary operator
  Add reference to commit message conventions

Author: javiereguiluz

contributing/code/conventions.rst

@@ -99,9 +99,9 @@ conventions:
 
 * No third level sections are allowed;
 
-* Messages should follow the commit message conventions: should be short,
-  capitalize the line, do not end with a period, use an imperative verb to
-  start the line;
+* Messages should follow the :ref:`commit message conventions <commit-messages>`:
+  should be short, capitalize the line, do not end with a period, use an
+  imperative verb to start the line;
 
 * New entries must be added on top of the list.
 

contributing/code/pull_requests.rst

@@ -224,6 +224,8 @@ in mind the following:
 * Never fix coding standards in some existing code as it makes the code review
   more difficult;
 
+.. _commit-messages:
+
 * Write good commit messages: Start by a short subject line (the first line),
   followed by a blank line and a more detailed description.
 

form/dynamic_form_modification.rst

@@ -377,6 +377,8 @@ sport like this::
     // src/Form/Type/SportMeetupType.php
     namespace App\Form\Type;
 
+    use App\Entity\Position;
+    use App\Entity\Sport;
     use Symfony\Bridge\Doctrine\Form\Type\EntityType;
     use Symfony\Component\Form\AbstractType;
     use Symfony\Component\Form\FormBuilderInterface;
@@ -390,7 +392,7 @@ sport like this::
         {
             $builder
                 ->add('sport', EntityType::class, [
-                    'class'       => 'App\Entity\Sport',
+                    'class' => Sport::class,
                     'placeholder' => '',
                 ])
             ;
@@ -407,7 +409,7 @@ sport like this::
                     $positions = null === $sport ? [] : $sport->getAvailablePositions();
 
                     $form->add('position', EntityType::class, [
-                        'class' => 'App\Entity\Position',
+                        'class' => Position::class,
                         'placeholder' => '',
                         'choices' => $positions,
                     ]);
@@ -443,6 +445,7 @@ The type would now look like::
     // src/Form/Type/SportMeetupType.php
     namespace App\Form\Type;
 
+    use App\Entity\Position;
     use App\Entity\Sport;
     use Symfony\Bridge\Doctrine\Form\Type\EntityType;
     use Symfony\Component\Form\FormInterface;
@@ -454,7 +457,7 @@ The type would now look like::
         {
             $builder
                 ->add('sport', EntityType::class, [
-                    'class'       => 'App\Entity\Sport',
+                    'class' => Sport::class,
                     'placeholder' => '',
                 ])
             ;
@@ -463,7 +466,7 @@ The type would now look like::
                 $positions = null === $sport ? [] : $sport->getAvailablePositions();
 
                 $form->add('position', EntityType::class, [
-                    'class' => 'App\Entity\Position',
+                    'class' => Position::class,
                     'placeholder' => '',
                     'choices' => $positions,
                 ]);

validation/severity.rst

@@ -137,7 +137,7 @@ method. Each constraint exposes the attached payload as a public property::
     // Symfony\Component\Validator\ConstraintViolation
     $constraintViolation = ...;
     $constraint = $constraintViolation->getConstraint();
-    $severity = isset($constraint->payload['severity']) ? $constraint->payload['severity'] : null;
+    $severity = $constraint->payload['severity'] ?? null;
 
 For example, you can leverage this to customize the ``form_errors`` block
 so that the severity is added as an additional HTML class: