minor #20181 [Mailer] Remove unnecessary type checking for the method from SentMessageEvent (wkania)

xabbuh · xabbuh · commit 6634a89adb28 · 2024-09-01T08:57:40.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [Mailer] Remove unnecessary type checking for the method from SentMessageEvent The getMessage method has been returning **only** SentMessage from the very [beginning](https://github.com/symfony/symfony/pull/47080/files#diff-19459911f97144033a370e7d86ae4e3bab9833c03cfe42e1eb3d71da90b15097R26). Commits ------- 2bbdc99 Remove unnecessary type checking for the method from SentMessageEvent
diff --git a/mailer.rst b/mailer.rst
@@ -1728,14 +1728,10 @@ which is useful for debugging errors::
 
     use Symfony\Component\EventDispatcher\EventSubscriberInterface;
     use Symfony\Component\Mailer\Event\SentMessageEvent;
-    use Symfony\Component\Mailer\SentMessage;
 
     public function onMessage(SentMessageEvent $event): void
     {
         $message = $event->getMessage();
-        if (!$message instanceof SentMessage) {
-            return;
-        }
 
         // do something with the message
     }

Original file line number	Diff line number	Diff line change
`@@ -1728,14 +1728,10 @@ which is useful for debugging errors::`
`1728`	`1728`
`1729`	`1729`	`use Symfony\Component\EventDispatcher\EventSubscriberInterface;`
`1730`	`1730`	`use Symfony\Component\Mailer\Event\SentMessageEvent;`
`1731`		`- use Symfony\Component\Mailer\SentMessage;`
`1732`	`1731`
`1733`	`1732`	`public function onMessage(SentMessageEvent $event): void`
`1734`	`1733`	`{`
`1735`	`1734`	`$message = $event->getMessage();`
`1736`		`- if (!$message instanceof SentMessage) {`
`1737`		`- return;`
`1738`		`- }`
`1739`	`1735`
`1740`	`1736`	`// do something with the message`
`1741`	`1737`	`}`