minor #17919 [Security] Adding needsRehash() (ThomasLandauer)

javiereguiluz · javiereguiluz · commit 63338badccdf · 2023-02-20T12:57:45.000+01:00
This PR was merged into the 5.4 branch. Discussion ---------- [Security] Adding needsRehash() Page: https://symfony.com/doc/5.4/security/passwords.html#custom-password-hasher Adding this to comply with `PasswordHasherInterface` * I didn't check if this is really required in v5.4 already (but for sure in 6.2) Commits ------- a3bedbf Adding needsRehash()
diff --git a/security/passwords.rst b/security/passwords.rst
@@ -830,6 +830,12 @@ If you need to create your own, it needs to follow these rules:
 
             return $passwordIsValid;
         }
+
+        public function needsRehash(string $hashedPassword): bool
+        {
+            // Check if a password hash would benefit from rehashing
+            return $needsRehash;
+        }
     }
 
 Now, define a password hasher using the ``id`` setting:

Original file line number	Diff line number	Diff line change
`@@ -830,6 +830,12 @@ If you need to create your own, it needs to follow these rules:`
`830`	`830`
`831`	`831`	`return $passwordIsValid;`
`832`	`832`	`}`
	`833`	`+`
	`834`	`+ public function needsRehash(string $hashedPassword): bool`
	`835`	`+ {`
	`836`	`+ // Check if a password hash would benefit from rehashing`
	`837`	`+ return $needsRehash;`
	`838`	`+ }`
`833`	`839`	`}`
`834`	`840`
`835`	`841`	Now, define a password hasher using the ``id`` setting: