Merge branch '4.3' into 4.4

* 4.3:
  cs fix
  Fix inconsistent return points.
  [Config] Add handling for ignored keys in ArrayNode::mergeValues.
  Fix inconsistent return points.
  [Security/Core] UserInterface::getPassword() can return null
  [Router] Fix TraceableUrlMatcher behaviour with trailing slash
  Revert "bug #33092 [DependencyInjection] Improve an exception message (fabpot)"

Author: nicolas-grekas

ClockMock.php

@@ -26,6 +26,8 @@ public static function withClockMock($enable = null)
         }
 
         self::$now = is_numeric($enable) ? (float) $enable : ($enable ? microtime(true) : null);
+
+        return null;
     }
 
     public static function time()
@@ -55,6 +57,8 @@ public static function usleep($us)
         }
 
         self::$now += $us / 1000000;
+
+        return null;
     }
 
     public static function microtime($asFloat = false)

DeprecationErrorHandler.php

@@ -104,6 +104,8 @@ public static function collectDeprecations($outputFile)
             }
 
             $deprecations[] = [error_reporting(), $msg, $file];
+
+            return null;
         });
 
         register_shutdown_function(function () use ($outputFile, &$deprecations) {
@@ -122,7 +124,7 @@ public function handleError($type, $msg, $file, $line, $context = [])
 
         $deprecation = new Deprecation($msg, debug_backtrace(), $file);
         if ($deprecation->isMuted()) {
-            return;
+            return null;
         }
         $group = 'other';
 
@@ -161,6 +163,8 @@ public function handleError($type, $msg, $file, $line, $context = [])
         }
 
         ++$this->deprecations[$group.'Count'];
+
+        return null;
     }
 
     /**

Legacy/CoverageListenerTrait.php

@@ -91,11 +91,7 @@ private function findSutFqcn($test)
         $sutFqcn = str_replace('\\Tests\\', '\\', $class);
         $sutFqcn = preg_replace('{Test$}', '', $sutFqcn);
 
-        if (!class_exists($sutFqcn)) {
-            return;
-        }
-
-        return $sutFqcn;
+        return class_exists($sutFqcn) ? $sutFqcn : null;
     }
 
     public function __sleep()

Legacy/SymfonyTestsListenerTrait.php

@@ -320,6 +320,8 @@ public function handleError($type, $msg, $file, $line, $context = array())
             $msg = 'Unsilenced deprecation: '.$msg;
         }
         $this->gatheredDeprecations[] = $msg;
+
+        return null;
     }
 
     /**

bin/simple-phpunit.php

@@ -187,7 +187,7 @@ class SymfonyBlacklistPhpunit {}
 $argc = isset($_SERVER['argc']) ? $_SERVER['argc'] : 0;
 
 if ($PHPUNIT_VERSION < 8.0) {
-    $argv = array_filter($argv, function ($v) use (&$argc) { if ('--do-not-cache-result' !== $v) return true; --$argc; });
+    $argv = array_filter($argv, function ($v) use (&$argc) { if ('--do-not-cache-result' !== $v) return true; --$argc; return false; });
 } elseif (filter_var(getenv('SYMFONY_PHPUNIT_DISABLE_RESULT_CACHE'), FILTER_VALIDATE_BOOLEAN)) {
     $argv[] = '--do-not-cache-result';
     ++$argc;