Merge branch '4.3' into 4.4

* 4.3:
  [Mailer] Remove line breaks in email attachment content
  Update links to documentation
  [Validator] Add the missing translations for the Arabic (ar) locale
  ensure to expect no validation for the right reasons
  [PhpUnitBridge] Add test case for @expectedDeprecation annotation
  [PhpUnitBridge][SymfonyTestsListenerTrait] Remove $testsWithWarnings stack
  [Mailer][MailchimpBridge] Fix missing attachments when sending via Mandrill API
  [Mailer][MailchimpBridge] Fix incorrect sender address when sender has name
  [HttpClient] fix capturing SSL certificates with NativeHttpClient
  [TwigBridge][Form] Added missing help messages in form themes
  Update year in license files
  Update year in license files
  [HttpClient] fix typo
  [Console][FormatterHelper] Use helper strlen statically and remove duplicated code
  [Routing] Fix i18n routing when the url contains the locale
  Fix BC issue in phpDoc Reflection library
  [Translator] Performance improvement in MessageCatalogue and catalogue operations.

Author: nicolas-grekas

LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2014-2019 Fabien Potencier
+Copyright (c) 2014-2020 Fabien Potencier
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

Legacy/SymfonyTestsListenerForV5.php

@@ -47,11 +47,6 @@ public function startTest(\PHPUnit_Framework_Test $test)
         $this->trait->startTest($test);
     }
 
-    public function addWarning(\PHPUnit_Framework_Test $test, \PHPUnit_Framework_Warning $e, $time)
-    {
-        $this->trait->addWarning($test, $e, $time);
-    }
-
     public function endTest(\PHPUnit_Framework_Test $test, $time)
     {
         $this->trait->endTest($test, $time);

Legacy/SymfonyTestsListenerForV6.php

@@ -52,11 +52,6 @@ public function startTest(Test $test)
         $this->trait->startTest($test);
     }
 
-    public function addWarning(Test $test, Warning $e, $time)
-    {
-        $this->trait->addWarning($test, $e, $time);
-    }
-
     public function endTest(Test $test, $time)
     {
         $this->trait->endTest($test, $time);

Legacy/SymfonyTestsListenerForV7.php

@@ -55,11 +55,6 @@ public function startTest(Test $test): void
         $this->trait->startTest($test);
     }
 
-    public function addWarning(Test $test, Warning $e, float $time): void
-    {
-        $this->trait->addWarning($test, $e, $time);
-    }
-
     public function endTest(Test $test, float $time): void
     {
         $this->trait->endTest($test, $time);

Legacy/SymfonyTestsListenerTrait.php

@@ -40,7 +40,6 @@ class SymfonyTestsListenerTrait
     private $expectedDeprecations = array();
     private $gatheredDeprecations = array();
     private $previousErrorHandler;
-    private $testsWithWarnings;
     private $reportUselessTests;
     private $error;
     private $runsInSeparateProcess = false;
@@ -112,7 +111,6 @@ public function globalListenerDisabled()
     public function startTestSuite($suite)
     {
         $suiteName = $suite->getName();
-        $this->testsWithWarnings = array();
 
         foreach ($suite->tests() as $test) {
             if (!($test instanceof \PHPUnit\Framework\TestCase || $test instanceof TestCase)) {
@@ -236,13 +234,6 @@ public function startTest($test)
         }
     }
 
-    public function addWarning($test, $e, $time)
-    {
-        if ($test instanceof \PHPUnit\Framework\TestCase || $test instanceof TestCase) {
-            $this->testsWithWarnings[$test->getName()] = true;
-        }
-    }
-
     public function endTest($test, $time)
     {
         if (class_exists(DebugClassLoader::class, false)) {

Tests/ExpectedDeprecationAnnotationTest.php

@@ -0,0 +1,43 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Bridge\PhpUnit\Tests;
+
+use PHPUnit\Framework\TestCase;
+
+final class ExpectedDeprecationAnnotationTest extends TestCase
+{
+    /**
+     * Do not remove this test in the next major versions.
+     *
+     * @group legacy
+     *
+     * @expectedDeprecation foo
+     */
+    public function testOne()
+    {
+        @trigger_error('foo', E_USER_DEPRECATED);
+    }
+
+    /**
+     * Do not remove this test in the next major versions.
+     *
+     * @group legacy
+     *
+     * @expectedDeprecation foo
+     * @expectedDeprecation bar
+     */
+    public function testMany()
+    {
+        @trigger_error('foo', E_USER_DEPRECATED);
+        @trigger_error('bar', E_USER_DEPRECATED);
+    }
+}