Add void return types

Author: wouterj

ClassExistsMock.php

@@ -24,6 +24,8 @@ class ClassExistsMock
      * Configures the classes to be checked upon existence.
      *
      * @param array $classes Mocked class names as keys (case-sensitive, without leading root namespace slash) and booleans as values
+     *
+     * @return void
      */
     public static function withMockedClasses(array $classes)
     {
@@ -34,6 +36,8 @@ public static function withMockedClasses(array $classes)
      * Configures the enums to be checked upon existence.
      *
      * @param array $enums Mocked enums names as keys (case-sensitive, without leading root namespace slash) and booleans as values
+     *
+     * @return void
      */
     public static function withMockedEnums(array $enums)
     {
@@ -81,6 +85,9 @@ public static function enum_exists($name, $autoload = true)
         return isset(self::$enums[$name]) ? (bool) self::$enums[$name] : \enum_exists($name, $autoload);
     }
 
+    /**
+     * @return void
+     */
     public static function register($class)
     {
         $self = static::class;

ClockMock.php

@@ -59,6 +59,9 @@ public static function sleep($s)
         return 0;
     }
 
+    /**
+     * @return void
+     */
     public static function usleep($us)
     {
         if (null === self::$now) {
@@ -121,6 +124,9 @@ public static function hrtime($asNumber = false)
         return [(int) self::$now, (int) $ns];
     }
 
+    /**
+     * @return void
+     */
     public static function register($class)
     {
         $self = static::class;

DnsMock.php

@@ -36,6 +36,8 @@ class DnsMock
      * Configures the mock values for DNS queries.
      *
      * @param array $hosts Mocked hosts as keys, arrays of DNS records as returned by dns_get_record() as values
+     *
+     * @return void
      */
     public static function withMockedHosts(array $hosts)
     {
@@ -167,6 +169,9 @@ public static function dns_get_record($hostname, $type = \DNS_ANY, &$authns = nu
         return $records;
     }
 
+    /**
+     * @return void
+     */
     public static function register($class)
     {
         $self = static::class;

Legacy/ExpectDeprecationTraitBeforeV8_4.php

@@ -18,10 +18,8 @@ trait ExpectDeprecationTraitBeforeV8_4
 {
     /**
      * @param string $message
-     *
-     * @return void
      */
-    protected function expectDeprecation($message)
+    protected function expectDeprecation($message): void
     {
         // Expected deprecations set by isolated tests need to be written to a file
         // so that the test running process can take account of them.

Legacy/SymfonyTestsListenerTrait.php

@@ -107,13 +107,13 @@ public function __destruct()
         }
     }
 
-    public function globalListenerDisabled()
+    public function globalListenerDisabled(): void
     {
         self::$globallyEnabled = false;
         $this->state = -1;
     }
 
-    public function startTestSuite($suite)
+    public function startTestSuite($suite): void
     {
         $suiteName = $suite->getName();
 
@@ -188,14 +188,14 @@ public function startTestSuite($suite)
         }
     }
 
-    public function addSkippedTest($test, \Exception $e, $time)
+    public function addSkippedTest($test, \Exception $e, $time): void
     {
         if (0 < $this->state) {
             $this->isSkipped[\get_class($test)][$test->getName()] = 1;
         }
     }
 
-    public function startTest($test)
+    public function startTest($test): void
     {
         if (-2 < $this->state && $test instanceof TestCase) {
             // This event is triggered before the test is re-run in isolation
@@ -242,7 +242,7 @@ public function startTest($test)
         }
     }
 
-    public function endTest($test, $time)
+    public function endTest($test, $time): void
     {
         if ($file = getenv('SYMFONY_EXPECTED_DEPRECATIONS_SERIALIZE')) {
             putenv('SYMFONY_EXPECTED_DEPRECATIONS_SERIALIZE');
@@ -338,15 +338,10 @@ public static function handleError($type, $msg, $file, $line, $context = [])
         }
         self::$gatheredDeprecations[] = $msg;
 
-        return null;
+        return true;
     }
 
-    /**
-     * @param TestCase $test
-     *
-     * @return bool
-     */
-    private function willBeIsolated($test)
+    private function willBeIsolated(TestCase $test): bool
     {
         if ($test->isInIsolation()) {
             return false;
@@ -355,6 +350,6 @@ private function willBeIsolated($test)
         $r = new \ReflectionProperty($test, 'runTestInSeparateProcess');
         $r->setAccessible(true);
 
-        return $r->getValue($test);
+        return $r->getValue($test) ?? false;
     }
 }