Fix rollbar handler to use RollbarLogger with Monolog 2+
#559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
requested changes
Dec 7, 2025
| $config = $handler['config'] ?: []; | ||
| $config['access_token'] = $handler['token']; | ||
| $rollbar = new Definition('RollbarNotifier', [ | ||
| $rollbar = new Definition('Rollbar\RollbarLogger', [ |
Member
There was a problem hiding this comment.
The signature of the RollbarHandler was modified in Monolog 2.0.0 by Seldaek/monolog#1042. This class must be set conditionally depending on the Monolog version.
In MonologBundle v4, since Monolog 3 is required, we can make this change without condition.
GromNaN
force-pushed
the
patch-1
branch
2 times, most recently
from
79beaee to
9e7c69b
Compare
GromNaN
changed the title
rollbar handler to use RollbarLogger with Monolog 2+
GromNaN
approved these changes
Dec 7, 2025
Member
|
Thanks for fixing this bug @websirnik. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the compatibility with the latest Rollbar library. Rollbar has renamed their classes a while ago.