bug #548 Support null for the NullHandler (GromNaN)

This PR was merged into the 3.x branch.

Discussion
----------

Support `null` for the `NullHandler`

| Q             | A
| ------------- | ---
| Branch?       | 3.x
| Bug fix?      | yes
| New feature?  | yes
| Deprecations? | no
| Issues        | Fix #400 Fix #133
| License       | MIT

The XML config format doesn't support `'null'` string as its always converted to `NULL`, and Yaml requires `'null'` to be quoted.
In order to simplify the configuration, the `NULL` value is converted to `'null'` string by the configuration.

Commits
-------

047ba44 Support null for the NullHandler

Author: GromNaN

src/DependencyInjection/Configuration.php

@@ -451,10 +451,9 @@ public function getConfigTreeBuilder(): TreeBuilder
             ->children()
                 ->scalarNode('type')
                     ->isRequired()
-                    ->treatNullLike('null')
                     ->beforeNormalization()
-                        ->always()
-                        ->then(function ($v) { return strtolower($v); })
+                        ->ifString()->then(function ($v) { return strtolower($v); })
+                        ->ifNull()->then(function ($v) { return 'null'; })
                     ->end()
                 ->end()
                 ->scalarNode('id')->end() // service & rollbar

tests/DependencyInjection/FixtureMonologExtensionTestCase.php

@@ -13,6 +13,7 @@
 
 use Monolog\Handler\FingersCrossed\ErrorLevelActivationStrategy;
 use Monolog\Handler\NoopHandler;
+use Monolog\Handler\NullHandler;
 use Monolog\Processor\PsrLogMessageProcessor;
 use Symfony\Bundle\MonologBundle\DependencyInjection\Compiler\LoggerChannelPass;
 use Symfony\Bundle\MonologBundle\DependencyInjection\MonologExtension;
@@ -312,6 +313,16 @@ public function testNativeMailer()
         $this->assertSame(['addHeader', [['Foo: bar', 'Baz: inga']]], $methodCalls[1]);
     }
 
+    public function testTypeNull()
+    {
+        $container = $this->getContainer('type_null');
+
+        $logger = $container->getDefinition('monolog.handler.null_handler');
+
+        $this->assertSame(NullHandler::class, $logger->getClass());
+        $this->assertSame('DEBUG', $logger->getArgument(0));
+    }
+
     protected function getContainer($fixture)
     {
         $container = new ContainerBuilder();

tests/DependencyInjection/Fixtures/xml/type_null.xml

@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<container xmlns="http://symfony.com/schema/dic/services"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xmlns:monolog="http://symfony.com/schema/dic/monolog"
+    xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd
+        http://symfony.com/schema/dic/monolog http://symfony.com/schema/dic/monolog/monolog-1.0.xsd">
+
+    <monolog:config>
+        <monolog:handler
+            name="null_handler"
+            type="null" />
+    </monolog:config>
+</container>

tests/DependencyInjection/Fixtures/yml/type_null.yml

@@ -0,0 +1,4 @@
+monolog:
+    handlers:
+        null_handler:
+            type: null