Merge branch '2.8' into 3.4

* 2.8:
  Fix Clidumper tests
  Enable the fixer enforcing fully-qualified calls for compiler-optimized functions
  Apply fixers
  Disable the native_constant_invocation fixer until it can be scoped
  Update the list of excluded files for the CS fixer

Author: nicolas-grekas

Store/CombinedStore.php

@@ -46,7 +46,7 @@ public function __construct(array $stores, StrategyInterface $strategy)
     {
         foreach ($stores as $store) {
             if (!$store instanceof StoreInterface) {
-                throw new InvalidArgumentException(sprintf('The store must implement "%s". Got "%s".', StoreInterface::class, get_class($store)));
+                throw new InvalidArgumentException(sprintf('The store must implement "%s". Got "%s".', StoreInterface::class, \get_class($store)));
             }
         }
 
@@ -62,7 +62,7 @@ public function save(Key $key)
     {
         $successCount = 0;
         $failureCount = 0;
-        $storesCount = count($this->stores);
+        $storesCount = \count($this->stores);
 
         foreach ($this->stores as $store) {
             try {
@@ -92,7 +92,7 @@ public function save(Key $key)
 
     public function waitAndSave(Key $key)
     {
-        throw new NotSupportedException(sprintf('The store "%s" does not supports blocking locks.', get_class($this)));
+        throw new NotSupportedException(sprintf('The store "%s" does not supports blocking locks.', \get_class($this)));
     }
 
     /**
@@ -102,7 +102,7 @@ public function putOffExpiration(Key $key, $ttl)
     {
         $successCount = 0;
         $failureCount = 0;
-        $storesCount = count($this->stores);
+        $storesCount = \count($this->stores);
         $expireAt = microtime(true) + $ttl;
 
         foreach ($this->stores as $store) {
@@ -164,7 +164,7 @@ public function exists(Key $key)
     {
         $successCount = 0;
         $failureCount = 0;
-        $storesCount = count($this->stores);
+        $storesCount = \count($this->stores);
 
         foreach ($this->stores as $store) {
             if ($store->exists($key)) {

Store/MemcachedStore.php

@@ -31,7 +31,7 @@ class MemcachedStore implements StoreInterface
 
     public static function isSupported()
     {
-        return extension_loaded('memcached');
+        return \extension_loaded('memcached');
     }
 
     /**
@@ -71,7 +71,7 @@ public function save(Key $key)
 
     public function waitAndSave(Key $key)
     {
-        throw new InvalidArgumentException(sprintf('The store "%s" does not supports blocking locks.', get_class($this)));
+        throw new InvalidArgumentException(sprintf('The store "%s" does not supports blocking locks.', \get_class($this)));
     }
 
     /**

Store/RedisStore.php

@@ -35,7 +35,7 @@ class RedisStore implements StoreInterface
     public function __construct($redisClient, $initialTtl = 300.0)
     {
         if (!$redisClient instanceof \Redis && !$redisClient instanceof \RedisArray && !$redisClient instanceof \RedisCluster && !$redisClient instanceof \Predis\Client && !$redisClient instanceof RedisProxy) {
-            throw new InvalidArgumentException(sprintf('%s() expects parameter 1 to be Redis, RedisArray, RedisCluster or Predis\Client, %s given', __METHOD__, is_object($redisClient) ? get_class($redisClient) : gettype($redisClient)));
+            throw new InvalidArgumentException(sprintf('%s() expects parameter 1 to be Redis, RedisArray, RedisCluster or Predis\Client, %s given', __METHOD__, \is_object($redisClient) ? \get_class($redisClient) : \gettype($redisClient)));
         }
 
         if ($initialTtl <= 0) {
@@ -71,7 +71,7 @@ public function save(Key $key)
 
     public function waitAndSave(Key $key)
     {
-        throw new InvalidArgumentException(sprintf('The store "%s" does not supports blocking locks.', get_class($this)));
+        throw new InvalidArgumentException(sprintf('The store "%s" does not supports blocking locks.', \get_class($this)));
     }
 
     /**
@@ -141,10 +141,10 @@ private function evaluate($script, $resource, array $args)
         }
 
         if ($this->redis instanceof \Predis\Client) {
-            return call_user_func_array(array($this->redis, 'eval'), array_merge(array($script, 1, $resource), $args));
+            return \call_user_func_array(array($this->redis, 'eval'), array_merge(array($script, 1, $resource), $args));
         }
 
-        throw new InvalidArgumentException(sprintf('%s() expects been initialized with a Redis, RedisArray, RedisCluster or Predis\Client, %s given', __METHOD__, is_object($this->redis) ? get_class($this->redis) : gettype($this->redis)));
+        throw new InvalidArgumentException(sprintf('%s() expects been initialized with a Redis, RedisArray, RedisCluster or Predis\Client, %s given', __METHOD__, \is_object($this->redis) ? \get_class($this->redis) : \gettype($this->redis)));
     }
 
     /**

Store/SemaphoreStore.php

@@ -35,7 +35,7 @@ class SemaphoreStore implements StoreInterface
      */
     public static function isSupported($blocking = null)
     {
-        if (!extension_loaded('sysvsem')) {
+        if (!\extension_loaded('sysvsem')) {
             return false;
         }
 
@@ -81,7 +81,7 @@ private function lock(Key $key, $blocking)
         if (\PHP_VERSION_ID >= 50601) {
             $acquired = @sem_acquire($resource, !$blocking);
         } elseif (!$blocking) {
-            throw new NotSupportedException(sprintf('The store "%s" does not supports non blocking locks.', get_class($this)));
+            throw new NotSupportedException(sprintf('The store "%s" does not supports non blocking locks.', \get_class($this)));
         } else {
             $acquired = @sem_acquire($resource);
         }

Store/StoreFactory.php

@@ -35,6 +35,6 @@ public static function createStore($connection)
             return new MemcachedStore($connection);
         }
 
-        throw new InvalidArgumentException(sprintf('Unsupported Connection: %s.', get_class($connection)));
+        throw new InvalidArgumentException(sprintf('Unsupported Connection: %s.', \get_class($connection)));
     }
 }

Tests/Store/BlockingStoreTestTrait.php

@@ -39,7 +39,7 @@ public function testBlockingLocks()
         // Amount a microsecond used to order async actions
         $clockDelay = 50000;
 
-        if (\PHP_VERSION_ID < 50600 || defined('HHVM_VERSION_ID')) {
+        if (\PHP_VERSION_ID < 50600 || \defined('HHVM_VERSION_ID')) {
             $this->markTestSkipped('The PHP engine does not keep resource in child forks');
 
             return;