[DI][FrameworkBundle] ServiceLocator: fix XML descriptor to use dashes

Author: ogizanagi

Console/Descriptor/XmlDescriptor.php

@@ -437,7 +437,7 @@ private function getArgumentNodes(array $arguments, \DOMDocument $dom)
                     $argumentXML->appendChild($childArgumentXML);
                 }
             } elseif ($argument instanceof ServiceLocatorArgument) {
-                $argumentXML->setAttribute('type', 'service_locator');
+                $argumentXML->setAttribute('type', 'service-locator');
 
                 foreach ($this->getArgumentNodes($argument->getValues(), $dom) as $childArgumentXML) {
                     $argumentXML->appendChild($childArgumentXML);

Tests/Fixtures/Descriptor/builder_1_arguments.xml

@@ -24,7 +24,7 @@
       <argument type="service" id="definition_2"/>
     </argument>
     <argument type="closure-proxy" id="definition1" method="get"/>
-    <argument type="service_locator">
+    <argument type="service-locator">
       <argument key="def1" type="service" id="definition_1"/>
       <argument key="def2" type="service" id="definition_2"/>
     </argument>

Tests/Fixtures/Descriptor/definition_arguments_1.xml

@@ -21,7 +21,7 @@
     <argument type="service" id="definition_2"/>
   </argument>
   <argument type="closure-proxy" id="definition1" method="get"/>
-  <argument type="service_locator">
+  <argument type="service-locator">
     <argument key="def1" type="service" id="definition_1"/>
     <argument key="def2" type="service" id="definition_2"/>
   </argument>