feature #21478 [Asset] Add support for preloading with links and HTTP/2 push (dunglas)

fabpot · fabpot · commit 6617dc092762 · 2017-02-19T14:57:15.000-08:00
This PR was squashed before being merged into the 3.3-dev branch (closes #21478). Discussion ---------- [Asset] Add support for preloading with links and HTTP/2 push | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | todo Allows compatible clients to preload mandatory assets like scripts, stylesheets or images according to [the "preload" working draft of the W3C](https://www.w3.org/TR/preload/). Thanks to this PR, Symfony will automatically adds `Link` HTTP headers with a `preload` relation for mandatory assets. If an intermediate proxy supports HTTP/2 push, it will convert preload headers. For instance [Cloudflare supports this feature](https://blog.cloudflare.com/using-http-2-server-push-with-php/). It dramatically increases pages speed and make the web greener because only one TCP connection is used to fetch all mandatory assets (decrease servers and devices loads, improve battery lives). Usage: Updated version: ```html <html> <body> Hello <script src="{{ preload(asset('/scripts/foo.js'), 'script') }}"></script> </body> </html> ``` ~~First proposal:~~ ```html <html> <body> Hello <script src="{{ preloaded_asset('/scripts/foo.js', 'script') }}"></script> </body> </html> ``` - [x] Add tests Commits ------- 7bab21700d [Asset] Add support for preloading with links and HTTP/2 push
diff --git a/Resources/config/assets.xml b/Resources/config/assets.xml
@@ -38,5 +38,13 @@
 
         <service id="assets.empty_version_strategy" class="Symfony\Component\Asset\VersionStrategy\EmptyVersionStrategy" public="false" />
 
+        <service id="assets.preload_manager" class="Symfony\Component\Asset\Preload\PreloadManager" public="false" />
+
+        <service id="asset.preload_listener" class="Symfony\Component\Asset\EventListener\PreloadListener">
+            <argument type="service" id="assets.preload_manager" />
+
+            <tag name="kernel.event_subscriber" />
+        </service>
+
     </services>
 </container>
diff --git a/Tests/DependencyInjection/FrameworkExtensionTest.php b/Tests/DependencyInjection/FrameworkExtensionTest.php
@@ -376,6 +376,12 @@ public function testAssetsDefaultVersionStrategyAsService()
         $this->assertEquals('assets.custom_version_strategy', (string) $defaultPackage->getArgument(1));
     }
 
+    public function testAssetHasPreloadListener()
+    {
+        $container = $this->createContainerFromFile('assets');
+        $this->assertTrue($container->hasDefinition('asset.preload_listener'));
+    }
+
     public function testTranslator()
     {
         $container = $this->createContainerFromFile('full');
diff --git a/composer.json b/composer.json
@@ -60,6 +60,7 @@
     "conflict": {
         "phpdocumentor/reflection-docblock": "<3.0",
         "phpdocumentor/type-resolver": "<0.2.0",
+        "symfony/asset": "<3.3",
         "symfony/console": "<3.3",
         "symfony/serializer": "<3.3",
         "symfony/form": "<3.3",

Original file line number	Diff line number	Diff line change
`@@ -376,6 +376,12 @@ public function testAssetsDefaultVersionStrategyAsService()`
`376`	`376`	`$this->assertEquals('assets.custom_version_strategy', (string) $defaultPackage->getArgument(1));`
`377`	`377`	`}`
`378`	`378`
	`379`	`+ public function testAssetHasPreloadListener()`
	`380`	`+ {`
	`381`	`+ $container = $this->createContainerFromFile('assets');`
	`382`	`+ $this->assertTrue($container->hasDefinition('asset.preload_listener'));`
	`383`	`+ }`
	`384`	`+`
`379`	`385`	`public function testTranslator()`
`380`	`386`	`{`
`381`	`387`	`$container = $this->createContainerFromFile('full');`